-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: listtransactions crash #3231 #3256
Merged
rustyrussell
merged 3 commits into
ElementsProject:master
from
m-schmoock:fix/fundchannel_listtransaction
Nov 15, 2019
Merged
fix: listtransactions crash #3231 #3256
rustyrussell
merged 3 commits into
ElementsProject:master
from
m-schmoock:fix/fundchannel_listtransaction
Nov 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
changed the title
pytest: add test for raising listtransactions after funding
fix: issue #3231
Nov 12, 2019
m-schmoock
force-pushed
the
fix/fundchannel_listtransaction
branch
from
November 14, 2019 09:56
9392086
to
cfd4c2d
Compare
cdecker
requested changes
Nov 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you swap the order of the two commits? Otherwise testing after applying the first one would fail (bisectability).
m-schmoock
force-pushed
the
fix/fundchannel_listtransaction
branch
from
November 14, 2019 15:25
69f4cdb
to
cc2c4de
Compare
cdecker
reviewed
Nov 14, 2019
cdecker
approved these changes
Nov 14, 2019
m-schmoock
force-pushed
the
fix/fundchannel_listtransaction
branch
from
November 14, 2019 19:33
170a89a
to
68a8c73
Compare
m-schmoock
force-pushed
the
fix/fundchannel_listtransaction
branch
from
November 14, 2019 19:34
68a8c73
to
b4c3be9
Compare
okay, done from my side... |
Awesome, thanks @m-schmoock 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3231
Ready for Review and Merge