pytest: add test store announcement_signatures, cleanups and a small bugfix #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_start_channeld Fixes a corner case when reconnecting (which restarts channeld) at depth=6 where we didn't correctly send/respond with announce_signatures. NOTE: A complete restart of node may initialize channeld with unupdated height because of an unfinished rescan. But when rescan is finished, funding tx_watch is fired (at least once), which then tells channeld the latest depth.
Remote node may (incorrectly) not send announcement_signatures when reconnecting, so we we use a copy and can still re-announce. Also checks that we still send our announcement_signatures when reconnecting.
- mock_rpc function now returns full JSON-RPC response, is much cleaner - Since reached_announce_depth counting is fixed when starting channeld, we don't need the 7th block to tell depth anymore.
channeld/channel_wire.csv add missing newline
trueptolemy
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pytest
test_reconnect_remote_sends_no_sigs, which test #2619.Small fixes (incorrect log line and missing newline) to #2619.
Fix for counting
reached_announce_depthinpeer_start_channeld(was off by one).Cleanups in
test_funding_reorg_remote_lags.