listchannels throws DEPRECATED API USED message

[gallizoltan]

Issue and Steps to Reproduce

Since I've updated to v24.08 every time I call listchannels I've got a BROKEN log message. For example, I call:

$ lightning-cli listchannels 860433x1035x0

Then in the logs this appears:

2024-09-08T09:08:33.909Z **BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private by \"cli:listchannels#1264712/cln:listchannels#204126\"

I'm not sure what it means and what to do? What is the include_private? I can't see it among the listchannels parameters.

It is especially frustrating for me because I used to run rebalance, which calls tons of listchannels.

getinfo output

{
   "id": "xxx",
   "alias": "",
   "color": "ffffff",
   "num_peers": 40,
   "num_pending_channels": 0,
   "num_active_channels": 25,
   "num_inactive_channels": 0,
   "address": [
      {
         "type": "torv3",
         "address": "xxx.onion",
         "port": 9735
      }
   ],
   "binding": [
      {
         "type": "ipv6",
         "address": "::",
         "port": 9735
      },
      {
         "type": "ipv4",
         "address": "0.0.0.0",
         "port": 9735
      }
   ],
   "version": "v24.08-modded",
   "blockheight": 860443,
   "network": "bitcoin",
   "fees_collected_msat": 775363681,
   "lightning-dir": "/home/user/.lightning/bitcoin",
   "our_features": {
      "init": "08a0800a8a59a1",
      "node": "88a0800a8a59a1",
      "channel": "",
      "invoice": "02000002024100"
   }
}

[grubles]

Can confirm this happening for me too.

[rustyrussell]

I've got the fix, now to figure out why CI didn't detect this!