Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchinvoicedoes not recognise quantity param #6089

Closed
lnbc1QWFyb24 opened this issue Mar 12, 2023 · 0 comments · Fixed by #6090
Closed

fetchinvoicedoes not recognise quantity param #6089

lnbc1QWFyb24 opened this issue Mar 12, 2023 · 0 comments · Fixed by #6090
Assignees
@rustyrussell @vincenzopalazzo
Labels
bug
Milestone
v23.05

Comments

@lnbc1QWFyb24
Copy link

Issue and Steps to Reproduce

Getting an error when trying to use fetchinvoice with the quantity param:

Request:

lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2

Response:

{
   "code": -32602,
   "message": "quantity parameter required"
}

getinfo output

{
   "id": "026911e6f9a78efe254a54828873b9c3e25d18fcb3da66807e0791cc0e5cb2ac1a",
   "alias": "bob",
   "color": "026911",
   "num_peers": 4,
   "num_pending_channels": 0,
   "num_active_channels": 4,
   "num_inactive_channels": 0,
   "address": [
      {
         "type": "dns",
         "address": "bob",
         "port": 19846
      }
   ],
   "binding": [
      {
         "type": "ipv4",
         "address": "172.18.0.3",
         "port": 19846
      }
   ],
   "version": "v22.11-modded",
   "blockheight": 168,
   "network": "regtest",
   "msatoshi_fees_collected": 3302,
   "fees_collected_msat": "3302msat",
   "lightning-dir": "/home/clightning/.lightning/regtest",
   "our_features": {
      "init": "08a0800a0269a2",
      "node": "88a0800a0269a2",
      "channel": "",
      "invoice": "02000002024100"
   }
}
@rustyrussell rustyrussell self-assigned this Mar 13, 2023
@rustyrussell rustyrussell added this to the v23.05 milestone Mar 13, 2023
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 13, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
b3dff3e 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo mentioned this issue Mar 13, 2023
Merged
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 13, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
628df5e 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Changelog-Fixed: fetchinvoice: assign the quantity to the invrequest field

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 13, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
2218bcb 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Changelog-Fixed: fetchinvoice: assign the quantity to the invrequest field

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo self-assigned this Mar 13, 2023
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 13, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
f82f973 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Changelog-Fixed: fetchinvoice: assign the quantity to the invrequest field

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 14, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
52a59a9 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Changelog-Fixed: fetchinvoice: assign the quantity to the invrequest field

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 15, 2023
@vincenzopalazzo
plugin: fetchinvoice: assign the quantity to the invrequest field
78cb683 
assign the quantity field receive as RPC parameter inside the
invrequest field.

Changelog-Fixed: fetchinvoice: assign the quantity to the invrequest field

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 20, 2023
@vincenzopalazzo
plugin: fetchinvoice: set the quantity in invreq
23daecb 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix and now use the `quantity` field into the
invreq field.
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 20, 2023
@vincenzopalazzo
plugin: fetchinvoice: set the quantity in invreq
acf71ae 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
vincenzopalazzo added a commit that referenced this issue Mar 20, 2023
@vincenzopalazzo
plugin: fetchinvoice: set the quantity in invreq
fca6211 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: #6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
vincenzopalazzo added a commit to vincenzopalazzo/lightning that referenced this issue Mar 23, 2023
@vincenzopalazzo
plugin: fetchinvoice: set the quantity in invreq
27e181c 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this issue Mar 24, 2023
Closed
ddustin pushed a commit to ddustin/lightning that referenced this issue Apr 11, 2023
@vincenzopalazzo @ddustin
plugin: fetchinvoice: set the quantity in invreq
6461b4e 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
gkrizek pushed a commit to voltagecloud/lightning that referenced this issue Apr 26, 2023
@vincenzopalazzo @gkrizek
plugin: fetchinvoice: set the quantity in invreq
6de3ef3 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
ddustin pushed a commit to ddustin/lightning that referenced this issue May 12, 2023
@vincenzopalazzo @ddustin
plugin: fetchinvoice: set the quantity in invreq
b45128d 
While the user trying to fetch an invoice by specifing the quantity we do
not work as expected.

Running the command

```
lightning-cli fetchinvoice -k offer='lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqffqszsk2p6hycmgv9ek2grpyphxjcm9ypmkjer8v46pyzmhd9jxwet5wvhxxmmdzsqs593pq0ylsvakdua5h976f4g3eautgjt3udvtyga47eaw7339sjrhpwpwz' quantity=2
```

and we answer back with

```json
{
   "code": -32602,
   "message": "quantity parameter required"
}
```

This is caused because we forget to bind the `quanity` field from the
RPC into the `invrequest`.

Reported-by: @aaronbarnardsound
Link: ElementsProject#6089
Signed-off-by: Vincenzo Palazzo <[email protected]>
Changelog-EXPERIMENTAL: fetchinvoice: fix: do not ignore the `quantity` field
into the invreq field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

@vincenzopalazzo vincenzopalazzo

Labels
bug
Projects
None yet
Milestone
v23.05
Development

Successfully merging a pull request may close this issue.

plugin: fetchinvoice: assign the quantity to the invrequest field vincenzopalazzo/lightning
3 participants
@rustyrussell @vincenzopalazzo @lnbc1QWFyb24