strange corner case while sending a commit #6077
Comments
vincenzopalazzo
changed the title
|
"Corner case"? I have seen this message reported 7,470,648 times for 827 distinct channels so far this month. It seems like quite a common case. |
|
@whitslack you are special guys :) I think you had very big not data that can help to diagnostic this case! |
|
Note that this log line was broken for a long time(?): #5881 so this was probably supposed to be there all along but we didn't know. |
|
Ah, @instagibbs fixed the logging, so now we log this! And it's spammy :( The issue is that we want to send commitment_signed, but we're still waiting for their revoke_and_ack. We do the dumbest possible thing here, which is to retry in commit_time_msec (10 by default). We should actually catch this in the revoke_and_ack path instead. |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Mar 20, 2023
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: ElementsProject#6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
added a commit
that referenced
this issue
Mar 22, 2023
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: #6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
ddustin
pushed a commit
to ddustin/lightning
that referenced
this issue
Apr 11, 2023
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: ElementsProject#6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
gkrizek
pushed a commit
to voltagecloud/lightning
that referenced
this issue
Apr 26, 2023
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: ElementsProject#6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
ddustin
pushed a commit
to ddustin/lightning
that referenced
this issue
May 12, 2023
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: ElementsProject#6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue and Steps to Reproduce
I noted this on my core lightning node after receiving a unilateral close for a channel, and I found the following content in the logs
getinfooutput{ "id": "03e2408a49f07d2f4083a47344138ef89e7617e63919202c92aa8d49b574a560ae", "alias": "BRUCEWAINE", "color": "02bf81", "num_peers": 9, "num_pending_channels": 0, "num_active_channels": 7, "num_inactive_channels": 1, "address": [ { "type": "ipv4", "address": "65.108.246.14", "port": 9735 }, { "type": "ipv6", "address": "2a01:4f9:c012:6356::1", "port": 9735 }, { "type": "torv3", "address": "hvq7b3r7zekt2cz5a4o52ae4xbhddj5pplan7godpweyihbdmwuuxiqd.onion", "port": 9735 } ], "binding": [ { "type": "ipv4", "address": "0.0.0.0", "port": 9735 } ], "version": "v23.02", "blockheight": 779767, "network": "bitcoin", "lightning-dir": "/home/vincent/.lightning/bitcoin", "our_features": { "init": "08a0800a0269a2", "node": "88a0800a0269a2", "channel": "", "invoice": "02000002024100" } }The text was updated successfully, but these errors were encountered: