Version v0.7.3-113-gdda792c crashes all the time

[ghost]

Issue and Steps to Reproduce

Rebuilding the gossip_store didn't help.

Saved output:

2019-11-18T13:05:50.844Z INFO lightningd: Restarting onchaind for channel 2 2019-11-18T13:05:50.845Z UNUSUAL 021d2436cab847373a4212bf6d754ead5304f5d0791479643893a837b295f3441c-chan#2: Peer permanent failure in ONCHAIN: Funding transaction spent 2019-11-18T13:05:50.849Z INFO 021d2436cab847373a4212bf6d754ead5304f5d0791479643893a837b295f3441c-chan#2: State changed from ONCHAIN to FUNDING_SPEND_SEEN 2019-11-18T13:05:50.852Z INFO lightningd: Restarting onchaind for channel 1 2019-11-18T13:05:50.854Z UNUSUAL 02888244029c5909593038ab19f269947c720de3423e491791b46c7c92f76279b6-chan#1: Peer permanent failure in ONCHAIN: Funding transaction spent 2019-11-18T13:05:50.857Z INFO 02888244029c5909593038ab19f269947c720de3423e491791b46c7c92f76279b6-chan#1: State changed from ONCHAIN to FUNDING_SPEND_SEEN 2019-11-18T13:05:50.859Z INFO lightningd: Restarting onchaind for channel 4 2019-11-18T13:05:50.860Z UNUSUAL 02913d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187-chan#4: Peer permanent failure in ONCHAIN: Funding transaction spent 2019-11-18T13:05:50.862Z INFO 02913d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187-chan#4: State changed from ONCHAIN to FUNDING_SPEND_SEEN 2019-11-18T13:05:50.998Z INFO lightningd: -------------------------------------------------- 2019-11-18T13:05:50.998Z INFO lightningd: Server started with public key 026bc066924bca8a22e4baa751533bf2dda4161544d08dab544a001a5385ab0d0c, alias myshtery (color #23375f) and lightningd v0.7.3-113-gdda792c 2019-11-18T13:05:51.005Z INFO 021d2436cab847373a4212bf6d754ead5304f5d0791479643893a837b295f3441c-chan#2: State changed from FUNDING_SPEND_SEEN to ONCHAIN 2019-11-18T13:05:51.131Z INFO 02913d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187-chan#4: State changed from FUNDING_SPEND_SEEN to ONCHAIN 2019-11-18T13:05:51.670Z INFO 02888244029c5909593038ab19f269947c720de3423e491791b46c7c92f76279b6-chan#1: State changed from FUNDING_SPEND_SEEN to ONCHAIN 2019-11-18T13:05:55.668Z UNUSUAL 0245e5d03cf4387a7e430608e1a6717448876349720b5c9bdebf45b19f71a0404d-chan#5: Peer permanent failure in ONCHAIN: Funding transaction spent 2019-11-18T13:05:55.670Z INFO 0245e5d03cf4387a7e430608e1a6717448876349720b5c9bdebf45b19f71a0404d-chan#5: State changed from ONCHAIN to FUNDING_SPEND_SEEN 2019-11-18T13:05:56.066Z INFO 0245e5d03cf4387a7e430608e1a6717448876349720b5c9bdebf45b19f71a0404d-chan#5: State changed from FUNDING_SPEND_SEEN to ONCHAIN realloc(): invalid next size lightning_gossipd: FATAL SIGNAL 6 (version v0.7.3-113-gdda792c) 0x556c518302ba send_backtrace common/daemon.c:41 0x556c5183034d crashdump common/daemon.c:54 0x7efc57aeff1f ??? ???:0 0x7efc57aefe97 ??? ???:0 0x7efc57af1800 ??? ???:0 0x7efc57b3a896 ??? ???:0 0x7efc57b41909 ??? ???:0 0x7efc57b469b3 ??? ???:0 0x7efc57b49cfc ??? ???:0 0x556c51857864 tal_resize_ ccan/ccan/tal/tal.c:694 0x556c5182de4c stale_scids_remove gossipd/seeker.c:362 0x556c5182dee1 seek_any_stale_scids gossipd/seeker.c:383 0x556c5182dfe7 seeker_check gossipd/seeker.c:905 0x556c518339ee timer_expired common/timeout.c:39 0x556c5182343b main gossipd/gossipd.c:1687 0x7efc57ad2b96 ??? ???:0 0x556c5181d209 ??? ???:0 0xffffffffffffffff ??? ???:0 free(): corrupted unsorted chunks lightningd: gossipd failed (signal 6), exiting.

getinfo output

{ "id": "026bc066924bca8a22e4baa751533bf2dda4161544d08dab544a001a5385ab0d0c", "alias": "myshtery", "color": "23375f", "num_peers": 5, "num_pending_channels": 1, "num_active_channels": 0, "num_inactive_channels": 4, "address": [], "binding": [ { "type": "ipv4", "address": "192.168.178.20", "port": 9835 } ], "version": "v0.7.3-113-gdda792c", "blockheight": 604360, "network": "bitcoin", "msatoshi_fees_collected": 0, "fees_collected_msat": "0msat", "lightning-dir": "/home/user/.lightning_test" }

[rustyrussell]

Good catch, and great report. Reproducing now, then will write fix.

Thanks for the report!

[ghost]

I've seen the fix and understand why you're so glad I reported this: a c programmer's worst nightmare :-)