Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings during compilation #1540

Closed
jsarenik opened this issue Jun 4, 2018 · 5 comments
Closed

Warnings during compilation #1540

jsarenik opened this issue Jun 4, 2018 · 5 comments

Comments

@jsarenik
Copy link
Collaborator

jsarenik commented Jun 4, 2018

Issue and Steps to Reproduce

Following warnings can be seen while compiling lightning on recent Linux distributions.

$ make
...
  CC       ccan/ccan/crypto/sha512/libwallycore_la-sha512.lo
<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition
...
copying selected object files to avoid basename conflicts...
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
...

I am trying to compile rustyrussell/lightning@408dabb

getinfo output

not relevant

@jsarenik jsarenik changed the title WIP: Warnings during compilation on Alpine Linux Warnings during compilation on Alpine Linux Jun 4, 2018
@jsarenik
Copy link
Collaborator Author

jsarenik commented Jun 4, 2018

See https://gist.github.com/jsarenik/deac2376402cfb07ca6726bd7086cef2 for a full log which includes mentioned warnings.

@jsarenik jsarenik changed the title Warnings during compilation on Alpine Linux Warnings during compilation Jun 5, 2018
@cdecker
Copy link
Member

cdecker commented Jun 7, 2018

Seems to me like a dependency throwing some warnings, not much we can do about it on our end.

@jsarenik
Copy link
Collaborator Author

jsarenik commented Jun 8, 2018

Thanks for pointing out it was in external dependency. I was just focusing on seeing the warnings instead of reading the context.

rustyrussell pushed a commit that referenced this issue Jun 9, 2018
Fixes lots of extra warnings (#1540)
@jsarenik
Copy link
Collaborator Author

@cdecker
Copy link
Member

cdecker commented Jun 11, 2018

Thanks @jsarenik the upstream fix got merged and we'll upgrade libwally as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants