bcli: don't log failed sendrawtransaction attempts twice

They are already logged both in bcli, and in lightningd. This just adds a lot of noise to the logs. We keep successed attempts though for the tests. Signed-off-by: Antoine Poinsot <[email protected]>
ElementsProject · Apr 28, 2020 · e9533d3 · e9533d3
1 parent 476a9a6
commit e9533d3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/plugins/bcli.c b/plugins/bcli.c
@@ -625,8 +625,10 @@ static struct command_result *process_sendrawtransaction(struct bitcoin_cli *bcl
 {
 	struct json_stream *response;
 
-	plugin_log(bcli->cmd->plugin, LOG_DBG, "sendrawtx exit %i (%s)",
-		   *bcli->exitstatus, bcli_args(bcli));
+	/* This is useful for functional tests. */
+	if (*bcli->exitstatus == 0)
+		plugin_log(bcli->cmd->plugin, LOG_DBG, "sendrawtx exit %i (%s)",
+			   *bcli->exitstatus, bcli_args(bcli));
 
 	response = jsonrpc_stream_success(bcli->cmd);
 	json_add_bool(response, "success", *bcli->exitstatus == 0);