feat: output descriptor #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-matsuzawa
force-pushed
the
feature-output-descriptor
branch
from
69b06e4 to
dd57d85
Compare
|
@k-matsuzawa are you still planning to work on this? If so i'd be happy to review the Miniscript part if you rebase. |
k-matsuzawa
force-pushed
the
feature-output-descriptor
branch
from
dd57d85 to
a4ded1f
Compare
|
@darosior Thanks! |
|
Hi @k-matsuzawa @darosior Please review #310 if you have time. Closing in favour of the above PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I wanted to parse miniscript, I also implemented a function to parse the output descriptor (see #151 ).
I have confirmed the execution by ctypes in Python, but not in Java. Please check the API parameters are correct for using swig. 🙏