Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When RPC server disabled, only warn on validatepegin failure #768

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

instagibbs
Copy link
Collaborator

QT starts up normally, and fails when -server=1 is set, and continues otherwise, by turning off peg-in validation.

This should be tested on liquidv1 with fresh syncs.

@instagibbs instagibbs added the needs port Needs backport to a different branch label Nov 5, 2019
@stevenroose
Copy link
Member

ACK 674f3c7

stevenroose added a commit that referenced this pull request Nov 5, 2019
674f3c7 When RPC server disabled, only warn on validatepegin failure (Gregory Sanders)

Pull request description:

  QT starts up normally, and fails when `-server=1` is set, and continues otherwise, by turning off peg-in validation.

  This should be tested on liquidv1 with fresh syncs.

Tree-SHA512: acf188b2eead8db2f2b8d92ae90b510a05e6ab15639249917a3fb99bf3ec48b3d741e372a4bfcf44b8c632d199e56070bbfe1f6a69ef1c991f126b4d34b218a8
@stevenroose stevenroose merged commit 674f3c7 into ElementsProject:master Nov 5, 2019
@instagibbs instagibbs mentioned this pull request Nov 5, 2019
stevenroose added a commit that referenced this pull request Nov 5, 2019
558ea69 Correctly seed the liquidv1 paklist pre-dynafed (Gregory Sanders)
2362c00 When RPC server disabled, only warn on validatepegin failure (Gregory Sanders)

Pull request description:

  Needed for new release:

  #768
  #769
  #770

Tree-SHA512: d9512f1840309e83c8ead1a7868c935c17e4b6ea262f9be759e6bfb9b47279d2f19e389958f2e9589b385e9de24ecf4644fed2b6619f4e6c4c3278773baef2fc
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 9, 2020
apoelstra added a commit to apoelstra/elements that referenced this pull request Nov 10, 2020
stevenroose pushed a commit that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs port Needs backport to a different branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants