have peg-in witness creation strip witness for space savings #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be failing the bitcoind parent test with a txid mismatch? edit: oh of course, this fix is wrong. For elements<->elements chain it works, but not bitcoin serialization due to janky signaling of segwit tx. |
instagibbs
force-pushed
the
strip_claim_wit
branch
from
c648328 to
8d74dc6
Compare
|
Hopefully fixed :) too lazy to run locally with bitcoind |
instagibbs
force-pushed
the
strip_claim_wit
branch
from
8d74dc6 to
7737d29
Compare
|
Now passing all non-stalling tests @stevenroose |
|
ACK 7737d29 |
stevenroose
added a commit
that referenced
this pull request
Jun 5, 2019
7737d29 have peg-in witness creation strip witness for space savings (Gregory Sanders) Pull request description: Cheaper peg-in witness for those with segwit transactions in Bitcoin. resolves #628 Tree-SHA512: defc4f38b2456c6f45cf2ebd48a3d5f9e39544bd048606257ef6cf90623595c159f61e3df56845fb7a37a44b5019614e692663978a9664dd9b4d01b77bedeb86
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 3, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
gwillen
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheaper peg-in witness for those with segwit transactions in Bitcoin.
resolves #628