Fix a bunch of clippy lints and get CI working again #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will result in the rendered numbering being different from the numbering in the source code, but that's probably better than the existing situation where the "3b" item does not show up as an independent list item. There's no good way I can see to fix this because of limitations of rustfmt's list facilities. And anyway this is legacy code. So just do something that makes clippy happy.
The Concrete impl used a weird complier gitch `let pred = |x| pred(x)` to avoid an infinite recursion bug (which in turn triggered a compiler bug that they didn't fix even though I filed it a DAY AFTER IT WAS INTRODUCED ON NIGHTLY and instead they waited 3 months and released it on stable forcing me to backport a workaround to a gazillion versions of rust-miniscript). The bug was rust-lang/rust#110475 BTW, just to make sure this commit triggers another notification on that issue. Clippy doesn't like this. Clippy is obviously wrong but rather than having this stupid fight again just switch to a different idiom. Meanwhile, the Semantic impl of ForEachKey panics iff any keys are present, regardless of the closure passed to it. This is funny but completely useless and we should just remove it.
We should really move to a system of lockfiles (and more generally move to the rust-bitcoin-maintainer-tools set of scripts since the existing scripts are badly broken -- a "fuzz" job that sets an unused DO_LINT variable and never fuzzes; a DO_FMT flag in contrib/test.sh which is never set, etc) but this is an easy fix for now.
This is just copied from rust-bitcoin
apoelstra
force-pushed
the
2024-08--lints
branch
from
20d1aa9
to
e151a85
Compare
|
Ok, the CI failure is a real fuzz failure. It is saying that we need to backport rust-bitcoin/rust-miniscript#569 (which checks that descriptors have only valid characters when parsing, instead of doing this check in the middle of But I think we should deal with that later since this PR and #88 are already pretty big and we don't want too much happening at once. Ready for review. |
|
utACK e151a85 thanks for this little tedious but very important work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably needs #88 to go in in parallel.