Added some Move Prover spec by MoveBit. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
element2050
reviewed
Oct 17, 2022
| @@ -21,13 +26,24 @@ module Bridge::Bytes { | |||
| } else { | |||
| data_len | |||
| }; | |||
| while (i < actual_end) { | |||
| while ({ | |||
| spec { | |||
element2050
reviewed
Oct 17, 2022
| @@ -129,6 +142,13 @@ module Bridge::CrossChainLibrary { | |||
| get_book_keeper(n, (n - (n - 1) / 3), pub_key_list) | |||
| } | |||
|
|
|||
| spec verify_pubkey { | |||
| pragma verify = false; | |||
There was a problem hiding this comment.
有部分verify 设置的为false，是打开有什么问题吗？
There was a problem hiding this comment.
因为verify_pubkey函数调用了get_book_keeper函数，get_book_keeper函数里面调用StarcoinFramework里面Hash::keccak_256和Hash::ripemd160这两个函数，这两个函数的spec有问题，导致prover编译报错，所以添加了verify = false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.