-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflows for main branch and tags #20
Conversation
builder/export_container
Outdated
@@ -14,6 +14,8 @@ if [ -z "$1" ]; then | |||
else | |||
VERSION=$1 | |||
fi | |||
CONTAINER_NAME=$(cat ${GIT_ROOT}/configuration/build_config.yaml | grep Base-Name: | awk -F " " '{print $2}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use tooling like yq
to read out the values from the YAML file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, your call.
It would be possible, see e.g. this commit & check antonjahn@cd98ae5
tool | Pro | Con |
---|---|---|
awk | available on most linux boxes | syntax is not great |
yq | can work with more complex yaml files, syntax is clean, is available on github runners | scripts are called locally and maintainers need to get yq as a dependency, okayish for modern ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly take over from init_workspace. For the action we can change to yq if you prefer, for the init_workspace we will get rid of this when we have the image in the Github registry.
Changes
Tested:
build and tests checked locally and in the ci job itself.
tag automation tested on fork, where I recreated the v1.3.9 branch
Question: