Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflows for main branch and tags #20

Merged
merged 20 commits into from
Nov 8, 2024
Merged

Conversation

antonjahn
Copy link
Collaborator

@antonjahn antonjahn commented Nov 7, 2024

Changes

  • dropped elbe (layers + robot)
  • fixed robot tests (docker -it does not work in CI, there is no interactive tty)
  • renamed repo & image name, adjusted bash scripts in build/export/tests
  • new workflow on main & prs > build, tests
  • new workflow on tag > build, test, publish

Tested:
build and tests checked locally and in the ci job itself.
tag automation tested on fork, where I recreated the v1.3.9 branch

Question:

  • Should we recreate the v1.3.9 tag to trigger the publish job or create a new v1.3.10 tag. The resulting image / features should be identical, as only config files, support scripts and tests changed.
  • Recommendation: create v1.3.10 as we might need to troubleshoot the publish part in the Elektrobit org

@@ -14,6 +14,8 @@ if [ -z "$1" ]; then
else
VERSION=$1
fi
CONTAINER_NAME=$(cat ${GIT_ROOT}/configuration/build_config.yaml | grep Base-Name: | awk -F " " '{print $2}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use tooling like yq to read out the values from the YAML file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, your call.

It would be possible, see e.g. this commit & check antonjahn@cd98ae5

tool Pro Con
awk available on most linux boxes syntax is not great
yq can work with more complex yaml files, syntax is clean, is available on github runners scripts are called locally and maintainers need to get yq as a dependency, okayish for modern ubuntu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly take over from init_workspace. For the action we can change to yq if you prefer, for the init_workspace we will get rid of this when we have the image in the Github registry.

@antonjahn antonjahn merged commit ff87d31 into Elektrobit:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants