gpgme: working gpgme unit test prototype #2035

petermax2 · 2018-05-31T17:14:33Z

Affects #896 , #1973 , #2008

Purpose

This is just a unit test that is supposed to run on the build server.

PLEASE DO NOT MERGE!!

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar nothing
needs to be checked.

commit messages are fine ("module: short statement" syntax and refer to issues)
I added unit tests
I ran all tests locally and everything went fine
affected documentation is fixed
I added code comments, logging, and assertions (see doc/CODING.md)
meta data is updated (e.g. README.md of plugins)
release notes are updated (doc/news/_preparation_next_release.md)

@markus2330 please review my pull request

Affects ElektraInitiative#896 , ElektraInitiative#1973 , ElektraInitiative#2008

markus2330 · 2018-05-31T17:38:35Z

That was really quick! Thank you for testing this!

petermax2 · 2018-05-31T17:42:12Z

@ingwinlu Could you please help me to install ligpgme-dev in the build containers?

@markus2330 I started to work on this last week but did not find time, so far, to complete it.

petermax2 · 2018-05-31T17:43:53Z

I have a running unit test that creates a 1024 bit RSA key by utilizing gpgme. Let's see how the build server responds.

petermax2 · 2018-05-31T18:16:53Z

jenkins build libelektra please

petermax2 · 2018-05-31T18:18:51Z

jenkins build clang please

petermax2 · 2018-05-31T18:20:06Z

@ingwinlu

Trying to acquire lock on [docker-images]
Found 0 available resource(s). Waiting for correct amount: 1.
[docker-images] is locked, waiting...

I may have broken something. Sorry!

ingwinlu · 2018-05-31T18:30:10Z

That is on purpose. Only a single build is allowed to create docker images at a time (to avoid clogging the build system). This is further refined in #2003. I guess you had old builds running and hence the new ones were blocked. This is also improved in #2003 were new builds auto cancel the old ones.

There should be debian packages on sid and stretch for gpgme-dev: https://packages.debian.org/search?suite=default&section=all&arch=any&searchon=names&keywords=libgpgme-dev

What other questions did you have?

petermax2 · 2018-05-31T18:39:51Z

What other questions did you have?

Everything works 😃 Thank you for your quick response!

markus2330 · 2018-05-31T18:40:16Z

#2003 is merged now.

@ingwinlu Does @petermax2 now need to rebase or will the changes take effect immediately?

to test how the build server responds

petermax2 · 2018-05-31T19:48:08Z

jenkins build libelektra please

petermax2 · 2018-06-01T05:05:31Z

So we have a working key generation. GPGME created three 512 bit RSA private keys with sub-keys. 🎉

139/223 Test  #99: testmod_gpgme ............................   Passed   96.54 sec

I wanted to repeat the test more often, but ran into a time-out.

So far, gpgme looks promising. Maybe it would be worth the effort to replace my gpg.c module with gpgme?

ingwinlu · 2018-06-01T05:14:26Z

key generation is hard on the build server because there is only very little entropy

…

On 1 June 2018 at 07:05, Peter Nirschl ***@***.***> wrote: So we have a working key generation. GPGME created three 512 bit RSA private keys with sub-keys. 🎉 139/223 Test #99: testmod_gpgme ............................ Passed 96.54 sec I wanted to repeat the test more often, but ran into a time-out. So far, gpgme looks to be promising. Maybe it would be worth the effort to replace my gpg.c module with gpgme? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2035 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEOv-kD-A1-hOaQNYZkbk_y2QQN76aSCks5t4MubgaJpZM4UVa7u> .

markus2330 · 2018-06-01T08:33:55Z

An interesting case would be where the current test cases fail and only gpgme succeeds. Maybe you can run all crypto test cases in a loop until they fail? (while ctest -R crypt; do; done)

And afaik key generation isn't something our plugins do, so I would not test that.

petermax2 · 2018-06-02T07:30:41Z

I added the test case, which fails on the build server (for the crypto / fcrypt plugin), which is: importing the Elektra test key. I repeat the test case 20 times. Let's see how the build server responds.

markus2330 · 2018-06-02T08:02:59Z

Unfortunately the build server is down for the weekend.

I think we need to repeat this more than 20 times. Afaik in all build jobs of the last weeks the failure happened only once. And I think you need to repeat the whole test case (with ctest) so that actually a new TMPDIR/HOME is used.

markus2330 · 2018-06-03T08:37:35Z

src/plugins/gpgme/gpgme.c

+
+	gpgme_check_version (NULL);
+	setlocale (LC_ALL, "");
+	gpgme_set_locale (NULL, LC_CTYPE, setlocale (LC_CTYPE, NULL));


We should not globally change anything (and especially not locales, this might make applications dysfunctional). If we set it, it should only be done for the gpgme context but why set it at all?

It looks like gpgme is engineered properly, as far as I saw it everything seems to be operating only on its context (and never globally, except in gpgme_set_locale if a NULL pointer is passed).

It might be useful to allocate the gpgme context only once (in open), it might be faster then.

The gpgme manual recommends to set the locale for initializing gpgme. I am not sure why they recommend it.

It's fine for prototyping but probably should not be used like this in any released software.
What stands against creating a gpgme context to solve the issue (and not have to rely on maybe wonky locale)?

What stands against creating a gpgme context to solve the issue (and not have to rely on maybe wonky locale)?

It would lead to yet another configuration setting of the plugin. If the locales are broken, pinentries shown by other applications will be broken, too, won't they?

But if we set the locales for the context is a minor thing. I only wanted to note that we must not set it globally.

ingwinlu · 2018-06-04T10:05:21Z

The build server is currently configured to kill build jobs after a certain time of inactivity on stdout. This is to avoid zombie jobs.

The current key generation takes long enough without producing output that this policy is enforced.

petermax2 · 2018-06-19T17:23:23Z

I close this PR for now and continue the work later on.

gpgme: working gpgme unit test prototype

7f99b2c

Affects ElektraInitiative#896 , ElektraInitiative#1973 , ElektraInitiative#2008

petermax2 added work in progress build labels May 31, 2018

petermax2 added 3 commits May 31, 2018 19:19

gpgme: add gpgme to Dockerfile

6aed566

gpgme: add CMake module for finding the development files

ba5a2a3

gpgme: add gpgme to Dockerfiles

163e66c

gpgme: remove gpgme from sid build

f6ca660

gpgme: fix gpgme package in Dockerfile

9bc740a

gpgme: repeat key generation

91ce947

to test how the build server responds

petermax2 added 2 commits May 31, 2018 21:58

gpgme: reduce number of keys

f7ce7ce

gpgme: reduce key size in unit test

6870272

gpgme: add unit test that imports a key

f2e7ab7

markus2330 mentioned this pull request Jun 2, 2018

Buildserver documentation #1974

Closed

14 tasks

markus2330 reviewed Jun 3, 2018

View reviewed changes

petermax2 closed this Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gpgme: working gpgme unit test prototype #2035

gpgme: working gpgme unit test prototype #2035

petermax2 commented May 31, 2018

markus2330 commented May 31, 2018

petermax2 commented May 31, 2018 •

edited

Loading

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

ingwinlu commented May 31, 2018

petermax2 commented May 31, 2018 •

edited

Loading

markus2330 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented Jun 1, 2018 •

edited

Loading

ingwinlu commented Jun 1, 2018 via email

markus2330 commented Jun 1, 2018

petermax2 commented Jun 2, 2018 •

edited

Loading

markus2330 commented Jun 2, 2018

markus2330 Jun 3, 2018

petermax2 Jun 4, 2018

ingwinlu Jun 4, 2018

markus2330 Jun 5, 2018

ingwinlu commented Jun 4, 2018

petermax2 commented Jun 19, 2018

gpgme: working gpgme unit test prototype #2035

gpgme: working gpgme unit test prototype #2035

Conversation

petermax2 commented May 31, 2018

Purpose

Checklist

markus2330 commented May 31, 2018

petermax2 commented May 31, 2018 • edited Loading

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented May 31, 2018

ingwinlu commented May 31, 2018

petermax2 commented May 31, 2018 • edited Loading

markus2330 commented May 31, 2018

petermax2 commented May 31, 2018

petermax2 commented Jun 1, 2018 • edited Loading

ingwinlu commented Jun 1, 2018 via email

markus2330 commented Jun 1, 2018

petermax2 commented Jun 2, 2018 • edited Loading

markus2330 commented Jun 2, 2018

markus2330 Jun 3, 2018

Choose a reason for hiding this comment

petermax2 Jun 4, 2018

Choose a reason for hiding this comment

ingwinlu Jun 4, 2018

Choose a reason for hiding this comment

markus2330 Jun 5, 2018

Choose a reason for hiding this comment

ingwinlu commented Jun 4, 2018

petermax2 commented Jun 19, 2018

petermax2 commented May 31, 2018 •

edited

Loading

petermax2 commented May 31, 2018 •

edited

Loading

petermax2 commented Jun 1, 2018 •

edited

Loading

petermax2 commented Jun 2, 2018 •

edited

Loading