Elektra Web 1.5 #2029

omnidan · 2018-05-26T14:44:08Z

leftovers from web-ui 1.5 leftovers #1951
array key improvements from usability test
improved search kdb-find: initial commit #1947
test with Firefox ESR

@markus2330 please review

Release notes

Many UX improvements from the usability test!

search completely reworked - it does not act as a filter on already opened keys anymore, and instead searches the whole key database - feedback from the search was also greatly improved (pulsating while searching, glowing blue when done)
added "abort" buttons to dialogs to revert actions
added "create array" button to easily create arrays
removed confirmation dialog before deletion (undo can be used instead)
created a docker image: elektra/web
small fixes:
- updated visibility levels
- removed "done" button in main view
- fixed issues with the opener click area
- remove metakeys when they are set to the default value or empty/0

markus2330

Thank you for the PR! Some small comments.

markus2330 · 2018-05-26T19:08:49Z

src/tools/web/client/package-lock.json

@@ -11324,14 +11324,6 @@
        }
      }
    },
-    "react-tap-event-plugin": {


Could you please write docu how to udpate this file?

markus2330 · 2018-05-26T19:09:59Z

src/tools/web/client/src/components/TreeItem/dialogs/SettingsDialog.jsx

@@ -99,7 +99,12 @@ export default class SettingsDialog extends Component {
      }
      // persist value to kdb and show notification
      const { timeout } = this.state[key] || {}
-      setMeta(key, value)
+
+      // remove metakey when setting to 0


and empty value?

markus2330

Thank you for improving the docu!

markus2330 · 2018-05-29T13:50:43Z

src/tools/web/README.md

+  'binary',
+ 'check/something',
+]
+```


And then, how to do validation or similar?

omnidan · 2018-05-31T13:14:53Z

@markus2330 all tasks from #2032 should be done now, I also tested with Firefox ESR.

you can review already, because only the docker container for the live demo is missing now.

markus2330 · 2018-05-31T15:00:19Z

Thank you!

The docker container would make it easier to test (and reproduce) 😉

omnidan · 2018-05-31T15:29:14Z

@markus2330 I created a Dockerfile (see #1901 (comment)). I also released an image, but it is still 1.4.0 (as the Dockerfile builds from the official git repo). I am also building a beta release docker image for 1.5.0 right now.

markus2330 · 2018-05-31T16:33:45Z

I am okay with merging this PR so that creating the Docker image is easier. If everything is finished, please set "ready to merge".

markus2330 · 2018-05-31T16:36:41Z

src/tools/web/Dockerfile

@@ -0,0 +1,34 @@
+FROM ubuntu:16.04


Any reason why this file is not in scripts/docker/?

omnidan · 2018-05-31T18:01:35Z

@markus2330 I already created a 1.5.0-beta image, no worries. you can install it via:

docker run -d -it -p 33333:33333 -p 33334:33334 elektra/web:1.5.0-beta

ingwinlu · 2018-05-31T18:17:31Z

why the two ports? you are missing EXPOSE entries in the Dockerfile. You might also be interested in removing some layers to reduce image size and speed up builds.

Additionally you don't have a PID1 that controls signals sent to the container.

markus2330 · 2018-05-31T18:28:33Z

@omnidan Thank you, works for me. As said, mountpoints would make the image more interesting. (Maybe mount /tmp/hosts to not destroy anything.) What about providing a start-web script instead of creating it only for the docker image? And release notes are missing! You are welcome to highlight your changes.

@ingwinlu Thank you for reviewing the Dockerfile!

markus2330 · 2018-05-31T18:38:00Z

@omnidan small things: "edit value" does not automatically focus to the edit field. Please also check if tabs work as wanted (they also cycle in the background of the dialog). And numbering of arrays sometimes does not work (if I clicked somewhere else before.) Should I create an issue for this?

omnidan · 2018-06-01T09:55:36Z

@ingwinlu thanks for the hints! I added the two ports via EXPOSE. One port is for elektrad (33333), the other for webd/client (33334). I also tried reducing the image size by following instructions from: https://blog.florianlopes.io/5-tips-to-reduce-docker-image-size/

I'm not sure what you mean by "you don't have a PID 1" - I found out that nodejs is not supposed to run as PID 1 in docker: https://www.elastic.io/nodejs-as-pid-1-under-docker-images/

omnidan · 2018-06-01T10:05:13Z

@markus2330

"edit value" does not automatically focus to the edit field.

thanks for the hint - I fixed this!

Please also check if tabs work as wanted (they also cycle in the background of the dialog).

unfortunately trapping the focus in the dialog does not work with the current version of the UI library I use (MUI): mui/material-ui#4384

I tried using an external library to achieve this, but with the external library I can only trap focus within the dialog contents, which excludes the dialog buttons. so when I enable the focus trap, it is not possible to navigate to the dialog buttons anymore.

focus trapping dialogs are implemented in the latest beta version of MUI, however: mui/material-ui#10458 - should I make an issue about things that can be fixed by upgrading to MUI 1.0 when it comes out (selecting text when pressing the copy button, trapping focus in dialogs)?

And numbering of arrays sometimes does not work (if I clicked somewhere else before.)

Where did you click? I'm not sure how to reproduce this.

omnidan · 2018-06-01T10:12:24Z

@markus2330

Thank you, works for me. As said, mountpoints would make the image more interesting. (Maybe mount /tmp/hosts to not destroy anything.)

We could push an example kdb export to a git repo and then pull that to build the docker image for the live demo (I would create a separate image for that though).

And release notes are missing! You are welcome to highlight your changes.

I added them to the initial post of this PR!

markus2330 · 2018-06-02T18:10:29Z

Thank you, looks great.

But please describe changes in changelog (news). (your text in this PR is quite good, but it should be in doc/news/_preparation_next_release.md)

You can also finish (some) tasks of #2037 here.

markus2330 · 2018-06-06T06:44:45Z

jenkins build all please

markus2330 · 2018-06-09T15:59:32Z

Please add some info to the release notes.

markus2330 · 2018-06-18T17:05:15Z

Thank you. Seems like you need to rebase.

Verified build of HEAD under OpenBSD 6.3 with egcc/eg++ 4.9.4.

… directory" This reverts commit 98a27d6.

omnidan · 2018-06-18T17:54:07Z

@markus2330 done!

markus2330 · 2018-06-18T18:50:38Z

Thank you! Could you please rebase to get rid of the old commits.

@ingwinlu Can you take a look at the docker file?

omnidan · 2018-06-18T18:52:24Z

@markus2330 I already rebased, what do you mean "get rid of the old commits"?

markus2330 · 2018-06-18T18:57:40Z

The github view shows 250+ commits. Something seems to be wrong here.

markus2330 · 2018-06-18T18:58:22Z

And maybe it is a good idea to split the docker files and the WebUI changes.

omnidan · 2018-06-18T19:05:27Z

The github view shows 250+ commits. Something seems to be wrong here.

@markus2330 that is because I rebased and it added all commits from upstream master to the branch, they should not be duplicated after merging (it looked the same way when I rebased my previous PR).

BTW: you can see that the PR only has my changes when going to the "files" tab: https://github.com/ElektraInitiative/libelektra/pull/2029/files

omnidan · 2018-06-18T19:06:01Z

And maybe it is a good idea to split the docker files and the WebUI changes.

I will remove them from this PR for now and create a new PR with the updated docker files tomorrow.

markus2330 · 2018-06-19T11:34:53Z

There is still something very wrong in this PR. There are 250+ commits.

omnidan · 2018-06-19T11:44:12Z

@markus2330 as I said, that is a result of rebasing, it happened in the previous PR too. Look at the "Files changed" tab, it does not actually contain the changes of the commits.

omnidan · 2018-06-19T11:55:11Z

see #2099

ingwinlu · 2018-06-19T11:59:08Z

@omnidan out of curiosity: how do you rebase?

markus2330 · 2018-06-19T12:01:00Z

it happened in the previous PR too.

This does not say it was correct. It also messed up the history back then.

The problem is that the common commit is old (26.05) and that you rebased something that already contained a merge commit.

A rebase should be very simple in your case, nobody else modified the directories you are working in.

You can also create a new PR if it is easier for you.

omnidan · 2018-06-19T12:05:37Z

@ingwinlu https://help.github.com/articles/syncing-a-fork/ and then git rebase master

markus2330 · 2018-06-19T12:09:18Z

I do not think you should mix these two.

You can either merge with -ff or even -ff-only or do a pull with --rebase.

ingwinlu · 2018-06-19T12:33:17Z

Make sure upstream is really pointing at the correct repository via git remote -v.
Your process seems fine to me otherwise.

omnidan · 2018-06-19T12:35:51Z

@ingwinlu I read that it might be the way I created the branch, not the way I rebased: https://stackoverflow.com/a/40413455

omnidan mentioned this pull request May 26, 2018

web-ui 1.5 leftovers #1951

Closed

6 tasks

omnidan changed the title ~~WIP: Elektra Web 1.5~~ Elektra Web 1.5 May 26, 2018

omnidan added the work in progress label May 26, 2018

markus2330 reviewed May 26, 2018

View reviewed changes

markus2330 reviewed May 29, 2018

View reviewed changes

markus2330 reviewed May 31, 2018

View reviewed changes

omnidan added ready to merge and removed work in progress labels May 31, 2018

markus2330 removed the ready to merge label May 31, 2018

omnidan added the ready to merge label Jun 1, 2018

markus2330 mentioned this pull request Jun 2, 2018

Web UI 1.5 #2037

Closed

24 tasks

markus2330 removed the ready to merge label Jun 6, 2018

ingwinlu and others added 3 commits June 18, 2018 19:49

docker: Add release note

a072fe4

docker: fixup spelling in release notes

1bc9da4

OpenBSD Build: Update COMPILE.MD

dd05700

Verified build of HEAD under OpenBSD 6.3 with egcc/eg++ 4.9.4.

ingwinlu and others added 8 commits June 18, 2018 19:51

jenkins: fix archivation

7293fb3

Revert "fcrypt: consider TMP, TEMP, TEMPDIR for finding the temporary…

0fbd51d

… directory" This reverts commit 98a27d6.

doc: clean non active triggers

9117cd2

fcrypt: fix compiler warning

3ced341

add changelog for elektra web 1.5

9daccda

remove debug messages

1eac23c

implement renaming keys

636dfe4

get rid of linter warnings

9ac89e0

Merge branch 'master' into elektra-web1.5

48f29b2

omnidan added 2 commits June 18, 2018 21:08

remove dockerfile from this PR

d7be28b

add elektra web 1.5 video to release notes

9545426

omnidan mentioned this pull request Jun 19, 2018

Elektra Web 1.5 (fixed) #2099

Closed

omnidan closed this Jun 19, 2018

omnidan mentioned this pull request Jun 19, 2018

Elektra Web 1.5 (final) #2101

Merged

Elektra Web 1.5 #2029

Elektra Web 1.5 #2029

Conversation

omnidan commented May 26, 2018 • edited Loading

Release notes

markus2330 left a comment

Choose a reason for hiding this comment

markus2330 May 26, 2018

Choose a reason for hiding this comment

markus2330 May 26, 2018

Choose a reason for hiding this comment

markus2330 left a comment

Choose a reason for hiding this comment

markus2330 May 29, 2018

Choose a reason for hiding this comment

omnidan commented May 31, 2018

markus2330 commented May 31, 2018 • edited Loading

omnidan commented May 31, 2018 • edited Loading

markus2330 commented May 31, 2018

markus2330 May 31, 2018

Choose a reason for hiding this comment

omnidan commented May 31, 2018

ingwinlu commented May 31, 2018

markus2330 commented May 31, 2018

markus2330 commented May 31, 2018

omnidan commented Jun 1, 2018

omnidan commented Jun 1, 2018 • edited Loading

omnidan commented Jun 1, 2018

markus2330 commented Jun 2, 2018 • edited Loading

markus2330 commented Jun 6, 2018

markus2330 commented Jun 9, 2018

markus2330 commented Jun 18, 2018

omnidan commented Jun 18, 2018

markus2330 commented Jun 18, 2018

omnidan commented Jun 18, 2018

markus2330 commented Jun 18, 2018

markus2330 commented Jun 18, 2018

omnidan commented Jun 18, 2018 • edited Loading

omnidan commented Jun 18, 2018

markus2330 commented Jun 19, 2018

omnidan commented Jun 19, 2018

omnidan commented Jun 19, 2018

ingwinlu commented Jun 19, 2018

markus2330 commented Jun 19, 2018

omnidan commented Jun 19, 2018

markus2330 commented Jun 19, 2018

ingwinlu commented Jun 19, 2018

omnidan commented Jun 19, 2018

omnidan commented May 26, 2018 •

edited

Loading

markus2330 commented May 31, 2018 •

edited

Loading

omnidan commented May 31, 2018 •

edited

Loading

omnidan commented Jun 1, 2018 •

edited

Loading

markus2330 commented Jun 2, 2018 •

edited

Loading

omnidan commented Jun 18, 2018 •

edited

Loading