Eliminated need to write to temporary file in disk #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_propka() in main.py now uses StringIO(), making it run entirely in memory and avoiding creating temp file on disk.
replaced temp file in run_propka() with StringIO()
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 65.40% 65.38% -0.02%
==========================================
Files 30 30
Lines 7792 7788 -4
==========================================
- Hits 5096 5092 -4
Misses 2696 2696
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_propka() in main.py now uses a String.IO() object, a file-like object stored in memory instead of a temporary file in disk.
A StringIO() stream object does not have a .name attribute and propka_input.read_molecule_file() requires a name with a valid ".pdb" extension when passing streams, hence the use of a generic "input.pdb" string as argument.