Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set fixed eletron-builder version #855

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Set fixed eletron-builder version #855

wants to merge 3 commits into from

Conversation

Thokerb
Copy link

@Thokerb Thokerb commented Jun 5, 2024

Set fixed electron-builder version to avaoid third party dependency errors

Related to #854

@Thokerb Thokerb marked this pull request as draft June 5, 2024 08:44
@Thokerb
fix wrong electron-version
043d2a0 
due to wrong initial base branch
@Thokerb Thokerb marked this pull request as ready for review June 5, 2024 08:46
FlorianRappl
FlorianRappl approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is a bit problematic, but for now it's a solid workaround.

In the future we may want to either make this configurable, or keep it properly maintained / change it regularly at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thokerb @FlorianRappl