-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for Review] A basic API #652
base: develop
Are you sure you want to change the base?
Conversation
I'll definitly use your api in my mod 😆 |
Currently doing some testing with @DonBruce64 via Gitter. If everything works out there, this should be good for a merge. |
Well... I'm still waiting... |
Could you merge the current |
550aa60
to
4b0e42f
Compare
Just rebased this onto develop again. Haven't had a chance to make sure its still good, |
Code cleanup to fix errors after rebase onto current dev Also implements some recommended things from IntelliJ
Oh dear, it's been a while. We're pretty close to a functioning 1.10 port by this point, or at least a compiling one. That's the ideal time to change / add APIs, so I'll look at this once we get there. It should just be a few days now. |
Great, I'll get this updated again soon. Looks like its gotten out of date again. |
Alas. I promise I won't ignore it again! |
@Baughn suggested I start a PR for this to get some feedback. At the moment this is a very basic API to allow the manipulation of recipes and fuels by other mods.
This uses a lot of reflection, and a bit of shuffling of some of the existing internal API-like stuff to try and make sure that there won't be any crashes if someone bundles and calls this without ELN loaded.
Allow other mods to use the API to connect components to the grid.I've been told this is being done as part of the 1.10 port now.This change is