Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code syntax highlighting colors #16

Closed
ElectricRCAircraftGuy opened this issue Nov 13, 2021 · 4 comments
Closed

Fix code syntax highlighting colors #16

ElectricRCAircraftGuy opened this issue Nov 13, 2021 · 4 comments
Labels
enhancement New feature or request highest priority

Comments

@ElectricRCAircraftGuy
Copy link
Owner

ElectricRCAircraftGuy commented Nov 13, 2021 •
edited
Loading

I don't like the dark syntax highlighting background and colors. Fix them to be light, like GitHub or Stack Overflow.

See:

  1. https://github.com/mmistakes/minimal-mistakes/issues?q=is%3Aissue+author%3A%40me+is%3Aclosed
    1. In particular: Overriding all base16 colors possible still leaves grey lines I can't get rid of mmistakes/minimal-mistakes#2770
  2. https://github.com/mmistakes/minimal-mistakes/pulls?q=is%3Apr+author%3A%40me+is%3Aclosed
    1. In particular: Apply code highlighting background to code in HTML headers <h1> through <h6> mmistakes/minimal-mistakes#2771
@ElectricRCAircraftGuy ElectricRCAircraftGuy changed the title Fix code syntax highlighting Fix code syntax highlighting colors Jun 18, 2023
@ElectricRCAircraftGuy
Copy link
Owner Author

Note: commit 464b72d made code format between backticks get properly highlighted even when within headings.

See:

git difftool 464b72d7eb92bd5e0dcb525e6c7f9ca05b8fcbbc~..464b72d7eb92bd5e0dcb525e6c7f9ca05b8fcbbc

@ElectricRCAircraftGuy
Copy link
Owner Author

From: http://localhost:4001/ydotool-tutorial/ and https://gabrielstaples.com/ydotool-tutorial/

I super hate it! I hate this dark color so much. I want it to look more like Stack Overflow instead.

image

ElectricRCAircraftGuy added a commit that referenced this issue Jun 18, 2023
@ElectricRCAircraftGuy
Fix code syntax highlighting to be light not dark!
9315052 
Use GitHub styling, from the bottom of this comment here:
mmistakes/minimal-mistakes#2770 (comment)

See also my comment here about how I think that CSS was generated!:
mmistakes/minimal-mistakes#2770 (comment)

Fixes issue #16

	modified:   _sass/minimal-mistakes/_syntax.scss
	new file:   _sass/minimal-mistakes/_syntax.scss.old
@ElectricRCAircraftGuy
Copy link
Owner Author

Fixed by the commit above!: 9315052

Much better! Here's what it looks like now!:

image

@ElectricRCAircraftGuy
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request highest priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ElectricRCAircraftGuy