Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle internationalized strings on windows #176

Open
AddressXception opened this issue May 4, 2021 · 1 comment
Open

handle internationalized strings on windows #176

AddressXception opened this issue May 4, 2021 · 1 comment
Labels
bug Something isn't working code owner only Only for Code Owner

Comments

@AddressXception
Copy link
Collaborator

Bug Report

Expected Behavior
international character sets are handled in utf-16

Actual Behavior
when marshalling strings from c# to the native library, the character set is misinterpreted. likely due ot the use of wide string and converting to string.

steps to reproduce:

netframework ManifestGenerator uncomment one of the lines that includes spanish language.
set a break in the Manifest.h c++/cli wrapper constructor after Utilities::MarshalString(json, _json);

expected: the string is properly translated
actual: the string has extra characters

Environment

  • OS: [e.g. OSX 10.13.4, Windows 10]
  • Version: [e.g. 1.0.1]
@AddressXception AddressXception added bug Something isn't working help wanted Extra attention is needed labels Aug 3, 2021
@AddressXception AddressXception added this to the Ada Lovelace 1.0.0 milestone Aug 3, 2021
@AddressXception AddressXception removed the help wanted Extra attention is needed label Sep 10, 2021
AddressXception added a commit that referenced this issue Sep 10, 2021
replace the hardcoded manifest with one that is not affected by #176
AddressXception added a commit that referenced this issue Sep 13, 2021
* 🚧 Adjust to Single Project

Shift project towards new csproj for C# project and away from Shared Setup.

Remove the shared project setup and start with .net standard 2.0 and .net framework 4.8 with the goal of adding more pieces including .net core. 

Fix tests

* 🙈 Ignore Test with Memory Address Issues

* ✨ Create Release Workflow

* ✨ Add links to README

* ♻️ Update Make

* 🚀 Add so, dylib, and dll to Release

* respect configuration when loading binaries

* use truncated manifest

replace the hardcoded manifest with one that is not affected by #176

* update readme and build tasks

* Remove msys package target

* try run netstandard tests

* only run netstandard tests on macos for now

* dont run tests

* 🧹 Update Test Project references

* 🧹 Quick Cleanup

Co-authored-by: Matt Wilhelm <[email protected]>
AddressXception added a commit that referenced this issue Sep 15, 2021
* 🚧 Adjust to Single Project

Shift project towards new csproj for C# project and away from Shared Setup.

Remove the shared project setup and start with .net standard 2.0 and .net framework 4.8 with the goal of adding more pieces including .net core. 

Fix tests

* 🙈 Ignore Test with Memory Address Issues

* ✨ Create Release Workflow

* ✨ Add links to README

* ♻️ Update Make

* 🚀 Add so, dylib, and dll to Release

* respect configuration when loading binaries

* use truncated manifest

replace the hardcoded manifest with one that is not affected by #176

* update readme and build tasks

* Remove msys package target

* try run netstandard tests

* only run netstandard tests on macos for now

* add chaum pedersen to C interface

* Add C# chaum pedersen proofs

* update version numbers

Co-authored-by: Keith Fung <[email protected]>
Co-authored-by: Keith Fung <[email protected]>
AddressXception added a commit that referenced this issue Sep 15, 2021
* 🚧 Adjust to Single Project

Shift project towards new csproj for C# project and away from Shared Setup.

Remove the shared project setup and start with .net standard 2.0 and .net framework 4.8 with the goal of adding more pieces including .net core. 

Fix tests

* 🙈 Ignore Test with Memory Address Issues

* ✨ Create Release Workflow

* ✨ Add links to README

* ♻️ Update Make

* 🚀 Add so, dylib, and dll to Release

* respect configuration when loading binaries

* use truncated manifest

replace the hardcoded manifest with one that is not affected by #176

* update readme and build tasks

* Remove msys package target

* try run netstandard tests

* only run netstandard tests on macos for now

* add chaum pedersen to C interface

* Add C# chaum pedersen proofs

* update version numbers

* rename x86 file

Co-authored-by: Keith Fung <[email protected]>
Co-authored-by: Keith Fung <[email protected]>
AddressXception added a commit that referenced this issue Sep 15, 2021
* 🚧 Adjust to Single Project

Shift project towards new csproj for C# project and away from Shared Setup.

Remove the shared project setup and start with .net standard 2.0 and .net framework 4.8 with the goal of adding more pieces including .net core. 

Fix tests

* 🙈 Ignore Test with Memory Address Issues

* ✨ Create Release Workflow

* ✨ Add links to README

* ♻️ Update Make

* 🚀 Add so, dylib, and dll to Release

* respect configuration when loading binaries

* use truncated manifest

replace the hardcoded manifest with one that is not affected by #176

* update readme and build tasks

* Remove msys package target

* try run netstandard tests

* only run netstandard tests on macos for now

* add chaum pedersen to C interface

* Add C# chaum pedersen proofs

* update version numbers

* rename x86 file

* do not upload 32 bit

* remove try

Co-authored-by: Keith Fung <[email protected]>
Co-authored-by: Keith Fung <[email protected]>
@lmarie79 lmarie79 added the code owner only Only for Code Owner label Sep 20, 2021
@AddressXception
Copy link
Collaborator Author

the dllimport calls probably need the charset explicitly set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code owner only Only for Code Owner
Projects
None yet
Development

No branches or pull requests

2 participants