Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix/configurable storage paths #55

Merged
merged 12 commits into from
Dec 5, 2019
Merged

Fix/configurable storage paths #55

merged 12 commits into from
Dec 5, 2019

Conversation

AddressXception
Copy link
Contributor

@AddressXception AddressXception commented Dec 3, 2019 •
edited by keithrfung
Loading

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • ✅ DO check open PR's to avoid duplicates.
  • ✅ DO keep pull requests small so they can be easily reviewed.
  • ✅ DO build locally before pushing.
  • ✅ DO make sure tests pass.
  • ✅ DO make sure any new changes are documented.
  • ✅ DO make sure not to introduce any compiler warnings.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

Description

This PR adds support for creating directories on paths if they do not already exist, when saving ballot and tally files out to the file system

💔Thank you!

pamtaro
pamtaro previously approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@pamtaro pamtaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just one file had some left-over changes and should be reverted

src/electionguard/voting/encrypter.c Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2019

This pull request introduces 1 alert when merging ac0e71c into a2a707e - view on LGTM.com

new alerts:

  • 1 for Missing header guard

pamtaro
pamtaro suggested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@pamtaro pamtaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unhappy build 😢

src/electionguard/directory.c Outdated Show resolved Hide resolved
pamtaro
pamtaro approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@pamtaro pamtaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@echumley-msft
Copy link
Collaborator

LGTM alert resolved. Merging.

@echumley-msft echumley-msft merged commit fb0fead into master Dec 5, 2019
@echumley-msft echumley-msft deleted the fix/configurable_storage_paths branch December 5, 2019 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pamtaro pamtaro pamtaro approved these changes

@keithrfung keithrfung Awaiting requested review from keithrfung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AddressXception @echumley-msft @pamtaro