Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fixing lgtm.yml to include test code+ small fix #41

Merged

Conversation

raulgarciamsft
Copy link
Contributor

@raulgarciamsft raulgarciamsft commented Nov 21, 2019

  • Fixing lgtm.yml to include test code
  • Fixing header guard for builtins.h

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Description

Please describe your pull request.

💔Thank you!

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2019

This pull request fixes 1 alert when merging 528fa77 into 7bf64a3 - view on LGTM.com

fixed alerts:

  • 1 for Missing header guard

@raulgarciamsft raulgarciamsft merged commit 80bd9c2 into Election-Tech-Initiative:master Nov 26, 2019
@raulgarciamsft raulgarciamsft deleted the raulgarcia_lgtm branch January 14, 2020 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants