This repository has been archived by the owner on May 13, 2024. It is now read-only.
Update Windows README + gitignore test executable #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithrfung
reviewed
Nov 11, 2019
.gitignore
Outdated
| ElectionGuardConfig.cmake | ||
| simple.exe |
There was a problem hiding this comment.
👉 hide whole simple folder
keithrfung
reviewed
Nov 11, 2019
There was a problem hiding this comment.
Leaving review up to @echumley-msft , but left comments to help along.
| cmake -G "MSYS Makefiles" .. | ||
| make | ||
| cmake -S . -B build -G "MSYS Makefiles" .. | ||
| cmake --build build |
There was a problem hiding this comment.
Good addition, the original commands were using an older version of cmake and building with make.
The newer version allows for autocreation of the folder.
|
|
||
| 3. You should now have a `libelectionguard.a`. | ||
| 3. You should now have a `electionguard.a` or `electionguard.dll` (depending on the how cmake was configured). |
There was a problem hiding this comment.
The commands listed in Step 2 should only build an artifact (.a).
It would only build a .dll if -DBUILD_SHARED_LIBS=ON is passed with command.
| cmake -G "MSYS Makefiles" .. | ||
| make | ||
| cmake -S examples/simple -B simple_build -G "MSYS Makefiles" | ||
| cmake --build simple_build --target simple |
echumley-msft
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨Please review the guidelines for contributing to this repository.
Description
Updated documentation to run on Windows. If CMAKE was never previously installed on the Windows machine (either from pacman inside of MSYS or in the Windows side from cmake.org), then using the cmake commands with
-G "MSYS Makefiles"will fail withError: Could not create named generator MSYS Makefiles. This adds that package to be installed via pacman during the initial setup of MSYS2. This also updates the cmake command's arguments to specify the source and build directories from the root of the project and run make through cmake for consistency. This PR also gitignores thesimple.exethat is generated from by the example build.