Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated Email Otp Authentication #245

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Integrated Email Otp Authentication #245

merged 2 commits into from
Aug 16, 2024

Conversation

aidaiym
Copy link
Collaborator

@aidaiym aidaiym commented Aug 13, 2024

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@aidaiym aidaiym added A0-ux PR changes the UX A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes labels Aug 13, 2024
@aidaiym aidaiym requested a review from Eldar2021 August 13, 2024 12:59
@aidaiym aidaiym self-assigned this Aug 13, 2024
Eldar2021
Eldar2021 reviewed Aug 14, 2024
View reviewed changes
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool but i have some questions

app/lib/config/router/app_router.dart Outdated Show resolved Hide resolved
app/lib/modules/login/presentation/view/sign_in_view.dart Outdated Show resolved Hide resolved
app/lib/modules/login/presentation/view/verification_code_view.dart Outdated Show resolved Hide resolved
app/test_driver/app/login/login_test.dart Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you test with integration test?

@Eldar2021 Eldar2021 self-requested a review August 16, 2024 03:52
Eldar2021
Eldar2021 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with apk and work well! Thank you very much

@Eldar2021 Eldar2021 merged commit a3cbe44 into main Aug 16, 2024
9 checks passed
@Eldar2021 Eldar2021 deleted the ai/auth branch August 16, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eldar2021 Eldar2021 Eldar2021 approved these changes

Assignees

@aidaiym aidaiym

Labels
A0-ux PR changes the UX A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidaiym @Eldar2021