Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote client package #241

Merged
merged 7 commits into from
Aug 11, 2024
Merged

Remote client package #241

merged 7 commits into from
Aug 11, 2024

Conversation

aidaiym
Copy link
Collaborator

@aidaiym aidaiym commented Aug 2, 2024

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@aidaiym aidaiym added A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes labels Aug 2, 2024
@aidaiym aidaiym requested a review from Eldar2021 August 2, 2024 06:27
@aidaiym aidaiym self-assigned this Aug 2, 2024
Eldar2021
Eldar2021 reviewed Aug 11, 2024
View reviewed changes
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Thank you!
But we need add some documentation and write test

packages/mq_remote_client/README.md Outdated
```dart
final result = await mqRemoteClient.get<Map<String, dynamic>>(
'https://example.com/api/resource',
fromJson: (json) => json,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fromJson: (json) => json, not need to await mqRemoteClient.get

packages/mq_remote_client/lib/mq_remote_client.dart Outdated
@@ -0,0 +1,6 @@
/// MQ remote client package
library;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add mq_remote_client

packages/mq_remote_client/lib/src/http_exception.dart Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documantation

packages/mq_remote_client/lib/src/network_client.dart Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation?

packages/mq_remote_client/test/src/mq_remote_client_test.dart Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo! We need write test for this pkg

@aidaiym aidaiym changed the title Remote config package Remote client package Aug 11, 2024
@Eldar2021 Eldar2021 self-requested a review August 11, 2024 18:35
Eldar2021
Eldar2021 approved these changes Aug 11, 2024
View reviewed changes
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write unit tests for this package with another PR?
We are ready to merge without unit tests

@Eldar2021 Eldar2021 merged commit f726c9f into main Aug 11, 2024
9 checks passed
@Eldar2021 Eldar2021 deleted the ai/mq-remote-client-package branch August 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eldar2021 Eldar2021 Eldar2021 approved these changes

Assignees

@aidaiym aidaiym

Labels
A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidaiym @Eldar2021