Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated sign in and sign up with firebase email and password #225

Closed
wants to merge 3 commits into from
Closed

Integrated sign in and sign up with firebase email and password #225

wants to merge 3 commits into from

Conversation

aidaiym
Copy link
Collaborator

@aidaiym aidaiym commented Jul 5, 2024 •
edited
Loading

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@aidaiym aidaiym added A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes labels Jul 5, 2024
Eldar2021
Eldar2021 reviewed Jul 6, 2024
View reviewed changes
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In generally very nice PR, thank you. But I have some suggestions.

app/lib/app/data/repository/auth_repositoty_impl.dart Outdated Show resolved Hide resolved
app/lib/app/data/repository/auth_repositoty_impl.dart Outdated Show resolved Hide resolved
app/lib/app/data/repository/auth_repositoty_impl.dart Show resolved Hide resolved
app/lib/app/data/source/auth_remote_data_source.dart Outdated Show resolved Hide resolved
app/lib/app/data/source/auth_remote_data_source.dart Show resolved Hide resolved
app/lib/modules/login/presentation/view/sign_up_view.dart Outdated Show resolved Hide resolved
app/lib/modules/login/presentation/view/sign_up_view.dart Outdated Show resolved Hide resolved
app/lib/utils/show/alerts.dart Outdated Show resolved Hide resolved
app/test_driver/app/login/login_test.dart Show resolved Hide resolved
app/test_driver/app_test.dart Outdated Show resolved Hide resolved
@Eldar2021 Eldar2021 removed their assignment Jul 6, 2024
@Eldar2021 Eldar2021 self-requested a review July 6, 2024 10:34
@aidaiym aidaiym closed this Jul 11, 2024
@Eldar2021 Eldar2021 deleted the ai/integrate-signin branch July 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eldar2021 Eldar2021 Awaiting requested review from Eldar2021

Assignees

@aidaiym aidaiym

Labels
A2-technical PR introduces technical changes B1-medium Elevates a release containing this PR to "medium priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidaiym @Eldar2021