fix: ssr incompatibility with vite 4 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fixes an incompatibility in
vite-plugin-rubywith Vite 4 when building for SSR, caused by the changes in:Background 📜
This was happening because we were configuring different
assetFilenamesfor a normal build than for SSR.Since
vite-plugin-ruby's overrides matched the convention in Vite 3, this bug did not manifest until vitejs/vite#10927, when the convention was changed from[name].[hash].[extname]to[name]-[hash].[extname].The Fix 🔨
Using the same
assetFilenamefor normal and SSR builds.Additionally, we no longer specify the
fileNamefor assets emitted invite-plugin-ruby, allowing Rollup to use the configuredassetFilename.