Bug when first argument is a string instead of an array of strings #9
Comments
jonaskuske
changed the title
jonaskuske
added a commit
to jonaskuske/kirbyup
that referenced
this issue
Aug 9, 2022
|
It's not a bug, the plugin is expecting an Array. If you have TypeScript in your editor it should warn you about it. I'm ok accepting a pull request to throw an explicit error if it's not an Array. |
|
Confused it with another of my plugins. Seems like |
11 tasks
|
Thanks! :) |
|
Thanks for reporting, released a fix in |
jonaskuske
added a commit
to jonaskuske/kirbyup
that referenced
this issue
Aug 13, 2022
johannschopplich
pushed a commit
to johannschopplich/kirbyup
that referenced
this issue
Aug 15, 2022
* feat: add support for `kirby serve` w/ HMR plugin * feat: allow HMR refresh, abort only on HMR reload * feat: rename module entry to _index.mjs makes it clearer that module entries are an internal, dev-only feature * docs: update examples to include serve script * feat: reload on PHP change in serve mode * feat: live-reload via CLI arg, CLI help, refactor * fix: only call server.close() if still listening * fix: set server.origin to serve assets in dev mode depends on vuejs/vue#12732 * fix: always pass array to vite-full-reload-plugin ElMassimo/vite-plugin-full-reload#9 * feat: specify port via cli instead of kirbyup conf * refactor: update reload-plugin, remove workaround * feat: make sure index.dev.mjs is gone after build * feat: set index.dev.mjs location with --out-dir * docs: update README for serve command * docs: capitalize "panel" * refactor: inline getViteConfig() type * fix: only handle SIGINT, implemented like vite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Works:
Breaks:
The argument is passed to
Array.from, sodir/*.phpis turned into['d', 'i', 'r', '/', '*', ...]! Now all of these are watched as separate globs, including*, so lots of watcher processes are spawned, every single file in the project is watched and the development server slows to a crawl.The text was updated successfully, but these errors were encountered: