Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added locales + fixes #3

Merged
merged 23 commits into from
Sep 16, 2022
Merged

Added locales + fixes #3

merged 23 commits into from
Sep 16, 2022

Conversation

TonybynMp4
Copy link
Contributor

@TonybynMp4 TonybynMp4 commented Sep 15, 2022 •
edited
Loading

fixed a few things i saw (shops problems, darkweb's crates and others) and added locales

@TonybynMp4 TonybynMp4 marked this pull request as draft September 15, 2022 21:35
@TonybynMp4 TonybynMp4 marked this pull request as ready for review September 15, 2022 22:51
uShifty
uShifty requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@uShifty uShifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some of the things I noticed if you could check them out otherwise the pr looks great

client/bennys.lua Outdated Show resolved Hide resolved
client/darkweb.lua Outdated Show resolved Hide resolved
server/boosting.lua Outdated Show resolved Hide resolved
shared/boosting.lua Outdated Show resolved Hide resolved
uShifty
uShifty reviewed Sep 15, 2022
View reviewed changes
client/darkweb.lua Outdated Show resolved Hide resolved
uShifty
uShifty requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@uShifty uShifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be the last things needed to change, But have you tested your PR?

server/shops.lua Outdated Show resolved Hide resolved
server/shops.lua Outdated Show resolved Hide resolved
@TonybynMp4
Copy link
Contributor Author

TonybynMp4 commented Sep 15, 2022 •
edited
Loading

These should be the last things needed to change, But have you tested your PR?

yeah actually x)
my broken config made all of those incorrect changes necessary

@uShifty
Copy link
Collaborator

uShifty commented Sep 15, 2022 •
edited
Loading

Looks good to me, but I will test it before approving and will let Lazzy and Zoo review this PR incase their is something I missed

@TonybynMp4
remove bugged notify + should fix the trackers not being yeeted
1991d5a 
the notify wouldn't give the correct time, just a random amount of seconds generated everytime you try to hack
@TonybynMp4
Update en.lua
03e27de
@TonybynMp4
Update fr.lua
171b70b
@TonybynMp4
Update boosting.lua
8131cbc
@TonybynMp4
Update boosting.lua
4c3cc01
@TonybynMp4
add time to another notify (#1)
9295113 
* Update en.lua

* Update fr.lua

* Update boosting.lua
@TonybynMp4
Copy link
Contributor Author

might be a problem with the delay / cooldown and with the tracker amount i'll test more tommorow

@JustLyy
Copy link
Contributor

JustLyy commented Sep 16, 2022

I will test it with and I will give you feedback

@JustLyy JustLyy merged commit d97ca60 into Ejiy:main Sep 16, 2022
@TonybynMp4 TonybynMp4 deleted the TonybynMp4-patch-1 branch March 6, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uShifty uShifty uShifty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TonybynMp4 @uShifty @JustLyy