-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ #170 Handle unauthorized error in health tracker #180
✨ #170 Handle unauthorized error in health tracker #180
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #180 +/- ##
===========================================
- Coverage 66.61% 66.37% -0.24%
===========================================
Files 70 73 +3
Lines 3082 3126 +44
===========================================
+ Hits 2053 2075 +22
- Misses 925 943 +18
- Partials 104 108 +4 ☔ View full report in Codecov by Sentry. |
@@ -40,6 +41,7 @@ func NewClient(providerConfig *Config, clientConfig *clients.ClientConfig, tel * | |||
chatURL: chatURL, | |||
config: providerConfig, | |||
chatRequestTemplate: NewChatRequestFromConfig(providerConfig), | |||
errMapper: NewErrorMapper(tel), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was time to break this thing into a smaller component. We may even end up having one error mapper if there is no much difference between error mapping across providers 👀
Handle a wrong API key case to make the model as unavailable permanently