iluwatar#2898 modified parent pom

Ehspresso · Apr 23, 2024 · b57721a · b57721a
1 parent 35bd486
commit b57721a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 34 deletions.
diff --git a/pom.xml b/pom.xml
@@ -58,6 +58,7 @@
     <sonar.projectName>Java Design Patterns</sonar.projectName>
   </properties>
   <modules>
+    <module>publish-subscribe</module>
     <module>abstract-factory</module>
     <module>collecting-parameter</module>
     <module>monitor</module>

diff --git a/publish-subscribe/pom.xml b/publish-subscribe/pom.xml
@@ -35,35 +35,19 @@
         <artifactId>java-design-patterns</artifactId>
         <version>1.26.0-SNAPSHOT</version>
     </parent>
-    <artifactId>publishsubscribe</artifactId>
+    <artifactId>publish-subscribe</artifactId>
 
     <dependencies>
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-api</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>org.mockito</groupId>
-            <artifactId>mockito-core</artifactId>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>org.apache.activemq</groupId>
             <artifactId>activemq-core</artifactId>
             <version>5.7.0</version>
         </dependency>
-        <dependency>
-            <groupId>org.apache.xbean</groupId>
-            <artifactId>xbean-spring</artifactId>
-            <version>4.24</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.activemq.tooling</groupId>
-            <artifactId>activemq-junit</artifactId>
-            <version>6.1.1</version>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 
 </project>
diff --git a/publish-subscribe/src/main/java/com/iluwatar/publishsubscribe/Borrower.java b/publish-subscribe/src/main/java/com/iluwatar/publishsubscribe/Borrower.java
@@ -1,7 +1,6 @@
 package com.iluwatar.publishsubscribe;
 
 import lombok.extern.slf4j.Slf4j;
-import org.slf4j.event.Level;
 import javax.jms.BytesMessage;
 import javax.jms.JMSException;
 import javax.jms.Message;
@@ -25,7 +24,7 @@ public class Borrower implements MessageListener {
   private TopicConnection tConnection;
   private TopicSession tSession;
   private Topic topic;
-  private double currentRate;
+  private final double currentRate;
   private static final String ERROR = "An error has occured!";
   private double newRate;
 

diff --git a/publish-subscribe/src/test/java/com/iluwatar/publishsubscribe/BorrowerTest.java b/publish-subscribe/src/test/java/com/iluwatar/publishsubscribe/BorrowerTest.java
@@ -1,25 +1,12 @@
 package com.iluwatar.publishsubscribe;
 
-import org.apache.activemq.Message;
-import org.apache.activemq.broker.Broker;
 import org.apache.activemq.broker.BrokerService;
-import org.apache.activemq.command.ActiveMQTextMessage;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import javax.jms.BytesMessage;
 import javax.jms.JMSException;
-import javax.jms.TextMessage;
-import java.io.BufferedOutputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.OutputStream;
-import java.io.PrintStream;
-import java.sql.SQLOutput;
-
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 public class BorrowerTest {
 

diff --git a/publish-subscribe/src/test/java/com/iluwatar/publishsubscribe/LenderTest.java b/publish-subscribe/src/test/java/com/iluwatar/publishsubscribe/LenderTest.java
@@ -2,10 +2,8 @@
 
 import org.apache.activemq.broker.BrokerService;
 import org.junit.jupiter.api.AfterAll;
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 public class LenderTest {