Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade undici to 7.x and expose re-exports in Undici module #4149

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

thewilkybarkid
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

https://github.com/nodejs/undici/releases/tag/v7.0.0

I could only find 1 change to match (removal of throwOnError).

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 0da4794

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@effect/platform-node Minor
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/sql-clickhouse Major
@effect/ai-openai Major
@effect/sql-d1 Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/sql-drizzle Major
@effect/sql-kysely Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

Might need a minor due to the dep upgrade - cc @tim-smart

@tim-smart
Copy link
Contributor

Will move it to peer deps too as we are exposing undici types.

@mikearnaldi
Copy link
Member

Will move it to peer deps too as we are exposing undici types.

using peerDependencies means that any major release of Undici leads to a major release of platform, if we are re-exporting it might be better to just use a dependency like we do with fast-check in effect

@tim-smart
Copy link
Contributor

Will switch to re-exports

@tim-smart tim-smart changed the title Use Undici 7 upgrade undici to 7.x and expose re-exports in Undici module Dec 16, 2024
@tim-smart tim-smart merged commit 011e2b6 into Effect-TS:main Dec 16, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
@thewilkybarkid thewilkybarkid deleted the undici-7 branch December 17, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants