Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the generic type order consistent in the Left, Right, and Either #3650

Open
wants to merge 3 commits into
base: next-major
Choose a base branch
from

Conversation

venusvavadiya
Copy link

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR makes the generic type order consistent between Left, Right, and Either. It updates Left<L, R> and Right<L, R> to Left<R, L> and Right<R, L>, respectively.

Copy link

changeset-bot bot commented Sep 21, 2024

🦋 Changeset detected

Latest commit: eab3dbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Major
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@venusvavadiya venusvavadiya changed the title Makes the generic type order consistent in the Left, Right, and Either Make the generic type order consistent in the Left, Right, and Either Sep 21, 2024
@mikearnaldi
Copy link
Member

Looks good but it's a breaking change so it would be for the next major

@venusvavadiya
Copy link
Author

Looks good but it's a breaking change so it would be for the next major

Thanks @mikearnaldi, I will add the necessary changeset.

@github-actions github-actions bot changed the base branch from main to next-major September 22, 2024 23:26
@github-actions github-actions bot force-pushed the next-major branch 17 times, most recently from 29a0e4a to f69e0e1 Compare September 25, 2024 01:30
@github-actions github-actions bot force-pushed the next-major branch 30 times, most recently from d7e544c to e44e0aa Compare October 14, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

2 participants