Fix following relative locations

Effect-TS · Jan 17, 2025 · 3fe172a · 3fe172a
1 parent ce0e614
commit 3fe172a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/.changeset/tiny-onions-change.md b/.changeset/tiny-onions-change.md
@@ -0,0 +1,5 @@
+---
+"@effect/platform": patch
+---
+
+Fix following relative locations
diff --git a/packages/platform/src/internal/httpClient.ts b/packages/platform/src/internal/httpClient.ts
@@ -711,7 +711,7 @@ export const followRedirects = dual<
               ? loop(
                 internalRequest.setUrl(
                   request,
-                  response.headers.location
+                  new URL(response.headers.location, response.request.url)
                 ),
                 redirects + 1
               )

diff --git a/packages/platform/test/HttpClient.test.ts b/packages/platform/test/HttpClient.test.ts
@@ -221,4 +221,20 @@ describe("HttpClient", () => {
       body: { _id: "@effect/platform/HttpBody", _tag: "Empty" }
     })
   })
+
+  it("followRedirects", () =>
+    Effect.gen(function*(_) {
+      const defaultClient = yield* HttpClient.HttpClient
+      const client = defaultClient.pipe(HttpClient.followRedirects())
+
+      const response = yield* _(
+        client.get("https://google.com/"),
+        Effect.scoped
+      )
+      expect(response.request.url).toBe("https://www.google.com/")
+    }).pipe(
+      Effect.provide(FetchHttpClient.layer),
+      Effect.provideService(FetchHttpClient.RequestInit, { redirect: "manual" }),
+      Effect.runPromise
+    ))
 })