Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming gender to sex #237

Merged
merged 9 commits into from
Jun 19, 2019
Merged

Renaming gender to sex #237

merged 9 commits into from
Jun 19, 2019

Conversation

mwhamgenomics
Copy link
Collaborator

@mwhamgenomics mwhamgenomics commented May 23, 2019

S E X

Closes #205. This will require a database key migration and will be backward-incompatible. The build will fail until EdinburghGenomics/EGCG-Core#106 is in master

…g-App into sex

# Conflicts:
#	etc/column_mappings.yaml
#	tests/test_rest_api/test_action/test_automatic_review.py
#	tests/test_rest_api/test_schema.py
…nto sex

# Conflicts:
#	tests/test_rest_api/test_action/test_automatic_review.py
@mwhamgenomics mwhamgenomics changed the base branch from master to Release_v0.22 June 7, 2019 10:07
…g-App into sex

# Conflicts:
#	database_versioning/v0.21_to_v0.22.py
@@ -62,8 +61,6 @@
'required_yield_q30': 95000000000,
'required_coverage': 30,
'required_yield': 120000000000,
'provided_gender': 'female',
'called_gender': 'male',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be replaced with their equivalent "sex" key, e.g. provided_gender becomes provided_sex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here - these fields are not used in automatic review, so there's no reason to have them in the test

@mwhamgenomics mwhamgenomics merged commit 343041a into Release_v0.22 Jun 19, 2019
@mwhamgenomics mwhamgenomics deleted the sex branch June 20, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants