MAINT: adapt MotifPssmPattern to modern biopython #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since biopython v1.82,
Bio.Align.AlignInfo.PSSM
class is deprecated (there's a v1.84 biopython out there already) andBio.motifs.Motif
is favored. Prior to this PR, the mentioned deprecated class serves as the input of the MotifPssmPattern constructor. However, the two helper class methods that load pssm files or alignment use Biopython's create/parse methods that return the recommendedBio.motifs.Motif
objects. For example, the following code fails with biopython>=1.82:The result is the following error:
AttributeError: 'PSSM' object has no attribute 'length'
The proposed PR adds a test case, changes the documented input class to
MotifPssmPattern
to the recommendedBio.motifs.Motif
, validates the input as such, and fixes the motif loading logic offrom_sequences
according to the changes in newer biopython.The proposed change suggests setting a minimally supported biopython version, but this seems beyond the scope of this PR.