Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:ci port conflict & merge pr#752 #754

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix:ci port conflict & merge pr#752 #754

merged 1 commit into from
Nov 21, 2023

Conversation

Kidr1cE
Copy link
Contributor

@Kidr1cE Kidr1cE commented Nov 10, 2023

What this PR does / why we need it:

  • fix:ci port conflict
  • Bump github.com/Azure/azure-sdk-for-go/sdk/azcore from 1.7.1 to 1.9.0

Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc8f898) 55.00% compared to head (dc07b74) 55.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          23       23           
  Lines        2287     2287           
=======================================
  Hits         1258     1258           
  Misses        915      915           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kidr1cE Kidr1cE changed the title fix:ci port conflict fix:ci port conflict & merge pr#752 Nov 10, 2023
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit e594893 into main Nov 21, 2023
15 checks passed
@tomqin93 tomqin93 deleted the fix-citest branch November 21, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants