Fix: Bump sigs.k8s.io/controller-runtime from 0.15.1 to 0.16.3 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-wangtongzhou
requested review from
saiyan86,
tomqin93 and
kris21he
as code owners
tomqin93
requested changes
Oct 22, 2023
pkg/deviceshifu/deviceshifutcp/etc/edgedevice/config/driverProperties
Outdated
Show resolved
Hide resolved
pkg/deviceshifu/deviceshifutcp/etc/edgedevice/config/instructions
Outdated
Show resolved
Hide resolved
pkg/deviceshifu/deviceshifutcp/etc/edgedevice/config/telemetries
Outdated
Show resolved
Hide resolved
|
tomqin93
reviewed
Oct 23, 2023
tomqin93
reviewed
Oct 24, 2023
pkg/k8s/crd/main.go
Outdated
| MetricsBindAddress: metricsAddr, | ||
| Port: 9443, | ||
| Scheme: scheme, | ||
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 54.88% 54.70% -0.18%
==========================================
Files 23 23
Lines 2283 2283
==========================================
- Hits 1253 1249 -4
- Misses 915 918 +3
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. |
|
fixed in #738, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-apimachinery-0.28.3