Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bump github.com/gopcua/opcua from 0.4.0 to 0.5.2 #735

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

cool-wangtongzhou
Copy link
Contributor

@cool-wangtongzhou cool-wangtongzhou commented Oct 20, 2023

fix: Bump github.com/gopcua/opcua from 0.4.0 to 0.5.2

@tomqin93 tomqin93 requested a review from rhoninl October 22, 2023 13:03
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cool-wangtongzhou added some comment, please take a look

@cool-wangtongzhou
Copy link
Contributor Author

@cool-wangtongzhou added some comment, please take a look
I have deleted unnecessary things, you can take a look.

tomqin93
tomqin93 previously approved these changes Oct 23, 2023
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cool-wangtongzhou cool-wangtongzhou changed the title fix: Bump github.com/gopcua/opcua from 0.4.0 to 0.5.2 Fix: Bump github.com/gopcua/opcua from 0.4.0 to 0.5.2 Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cc64637) 54.88% compared to head (4386cc9) 54.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   54.88%   54.91%   +0.03%     
==========================================
  Files          23       23              
  Lines        2283     2287       +4     
==========================================
+ Hits         1253     1256       +3     
- Misses        915      917       +2     
+ Partials      115      114       -1     
Files Coverage Δ
...g/deviceshifu/deviceshifuopcua/deviceshifuopcua.go 13.74% <0.00%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit fb07f3a into Edgenesis:main Oct 24, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants