Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pipeline mssql #718

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix pipeline mssql #718

merged 1 commit into from
Sep 27, 2023

Conversation

Yunxe
Copy link
Contributor

@Yunxe Yunxe commented Sep 27, 2023

What this PR does / why we need it:
fix pipeline mssql
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)
    azure pipeline
    Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eac3601) 55.10% compared to head (964a280) 54.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   55.10%   54.88%   -0.22%     
==========================================
  Files          23       23              
  Lines        2283     2283              
==========================================
- Hits         1258     1253       -5     
- Misses        911      915       +4     
- Partials      114      115       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 43503cc into main Sep 27, 2023
@tomqin93 tomqin93 deleted the fix-pipeline-myssql branch September 27, 2023 12:09
tomqin93 pushed a commit that referenced this pull request Sep 27, 2023
* bump tags to v0.28.0-rc1

* fix pipeline mssql (#718)

---------

Co-authored-by: Yunxe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants