Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lwm2m object response body pointer to avoid decode failed #1084

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Dec 18, 2024

What this PR does / why we need it:
if int value is 0 or empty string it will case decode error
Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)
    test with leshan
    Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (cfc8fd1) to head (a13bb41).
Report is 2 commits behind head on release_v0.60.0.

Files with missing lines Patch % Lines
pkg/gateway/lwm2m/client/object.go 12.50% 7 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release_v0.60.0    #1084      +/-   ##
===================================================
- Coverage            32.96%   32.94%   -0.03%     
===================================================
  Files                   55       55              
  Lines                 4875     4878       +3     
===================================================
  Hits                  1607     1607              
- Misses                3128     3131       +3     
  Partials               140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoninl rhoninl changed the base branch from main to release_v0.60.0 December 18, 2024 10:36
@tomqin93 tomqin93 merged commit 92d8341 into release_v0.60.0 Dec 19, 2024
15 of 17 checks passed
@tomqin93 tomqin93 deleted the lwm2m_object_field branch December 19, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants