Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): rotary encoder events not always working on some screens #5714

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions radio/src/gui/colorlcd/libui/table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -320,3 +320,13 @@ void TableField::setAutoEdit()
lv_group_set_editing(g, true);
}
}

void TableField::deleteLater(bool detach, bool trash)
{
if (!deleted())
if (autoedit) {
lv_group_t* g = (lv_group_t*)lv_obj_get_group(lvobj);
lv_group_set_focus_cb(g, nullptr);
lv_group_set_editing(g, false);
}
}
2 changes: 2 additions & 0 deletions radio/src/gui/colorlcd/libui/table.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,7 @@ class TableField : public Window
void onEvent(event_t event) override;
bool onLongPress() override;

void deleteLater(bool detach = true, bool trash = true) override;

static void force_editing(lv_group_t* g) { lv_group_set_editing(g, true); }
};
Loading