feat: User configurable audio mute #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
3djc
commented
Jun 21, 2023
3djc
commented
|
What is the downside of muting, or "why can't we enable muting by default"? |
Muting adds audio latency, especially important if you are gliding with vario for exemple |
|
I would suggest repurposing the unused 'spare4' bit variable for 'audioMuteEnable' instead of adding a new entry. |
Cannot agree more ! Done |
mha1
added a commit
to mha1/edgetx
that referenced
this pull request
Jun 22, 2023
|
@elecpower , fyi: #3710 |
pfeerick
approved these changes
Jun 24, 2023
|
I would have sworn when I changed branches of this before it said it was going to pull in two other commits it shouldn't have, but they're not there now 🤷 |
pfeerick
changed the title
pfeerick
force-pushed
the
3djc/user-conf-audio-mute
branch
from
ce5994d to
865d34a
Compare
pfeerick
pushed a commit
to mha1/edgetx
that referenced
this pull request
Jun 26, 2023
pfeerick
pushed a commit
that referenced
this pull request
Jun 26, 2023
* CPN: user configurable audio mute in radio settings. Supports PR #3703 * make checkbox only visible for radios with AUDIO_MUTE_GPIO pin: - All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8
3djc
added a commit
that referenced
this pull request
Jun 26, 2023
pfeerick
pushed a commit
that referenced
this pull request
Jun 30, 2023
* feat: User configurable audio mute (#3703 port to main) * chore: Add translations
pfeerick
pushed a commit
that referenced
this pull request
Jun 30, 2023
* CPN: user configurable audio mute in radio settings. Supports PR #3703 * make checkbox only visible for radios with AUDIO_MUTE_GPIO pin: - All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8
pfeerick
added a commit
that referenced
this pull request
Jul 1, 2023
* feat(cpn): User configurable audio mute in radio settings (#3710) * CPN: user configurable audio mute in radio settings. Supports PR #3703 * make checkbox only visible for radios with AUDIO_MUTE_GPIO pin: - All color lcd radios (including NV14) except Horus X12S - TX12, TX12MK2, ZORRO, BOXER, T8, TLITE, TPRO, LR3PRO, COMMANDO8 * chore: Add Companion translations --------- Co-authored-by: Michael <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.