CPN W64: simulator crashes on selection of FLYSKY external module

[mha1]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

W64 simulator crashes if FLYSKY is chosen as external RF module.

Expected Behavior

Don't crash

Steps To Reproduce

1. standalone simulator

• start Firmware Simulator 2.9
• goto model settings and select external RF module
• select FLYSKY

2. from Companion

• start Companion 2.9
• select File/New then click on +Model
• press cancel to exit the wizard
• double click on the newly created MODEL01
• select AFHDS3 as external radio module
• press simulate

Version

Nightly (Please give date/commit below)

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

Windows

OS Version

No response

Anything else?

Companion W64 build: Actions, main branch, Windows Companion 64-bit, chore: Translation catchup (#3619) - https://github.com/EdgeTX/edgetx/suites/13479597982/artifacts/740096546

Note: the crash was introduced with commit 125fd2b (#3442)

@richardclli: please check

[richardclli]

Note: the crash was introduced with commit 125fd2b (#3442)

@raphaelcoeffic The problematic code is your work. Not sure where is the best way to prevent SIMU to crash in your serial API.

[richardclli]

Interesting, cannot repeat this with Linux simulator. It will not crash.

[pfeerick]

Able to reproduce on WSL2 with current main (excuse the Japanese, didn't bother changing it from a prior test build), as well as native Windows Companion simulator.

https://github.com/EdgeTX/edgetx/tree/pfeerick/issue3682 is a tentative fix, until Raphael screams at me it's not the way to fix it 🤭

Code_ENBjNstwRn.mp4

[richardclli]

Interesting, if this is the problem, I should be able to repeat in Linux sim, obviously a nullptr problem.

[richardclli]

@pfeerick Please check if this PR has problem:

#3501

@raphaelcoeffic recommended this change and may solve the problem.

edgetx/radio/src/hal/module_port.h

Lines 147 to 155 in 97f514f

	inline const etx_serial_driver_t* modulePortGetSerialDrv(const etx_module_driver_t& d) {
	if (d.port == nullptr) return nullptr;
	return d.port->drv.serial;
	}
	inline const etx_timer_driver_t* modulePortGetTimerDrv(const etx_module_driver_t& d) {
	if (d.port == nullptr) return nullptr;
	return d.port->drv.timer;
	}

[pfeerick]

Yup, that nullptr check will do the trick. So was already fixed in #3501 .