Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative timer display #50

Merged

Conversation

offer-shmuely
Copy link
Contributor

fix issue #49

  • fix negative timer display
  • color red on negative display

before the fix:
image

after the fix:
image

color red on negative display
lcd.setColor(CUSTOM_COLOR, wgt.options.TextColor)
if (wgt == nil) then log("refresh(nil)") return end
if (wgt.options == nil) then log("refresh(wgt.options=nil)") return end
if (wgt.options.Timer == nil) then log("refresh(wgt.options.Timer=nil)") return end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD triggered! 😆

@pfeerick
Copy link
Member

Thank you! Yes, this did get a bit annoying when it started counting down from -1:59:54 when it had gone past 0... 😆

@pfeerick pfeerick merged commit 5e95c88 into EdgeTX:master Feb 13, 2022
@offer-shmuely offer-shmuely deleted the shmuely/fix_timer2_negative_display branch February 1, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

widget Timer2: invalid display on negative timer
3 participants