Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Danish voice #49

Merged
merged 8 commits into from
Oct 13, 2022
Merged

feat: Add Danish voice #49

merged 8 commits into from
Oct 13, 2022

Conversation

HThuren
Copy link
Contributor

@HThuren HThuren commented Oct 2, 2022

I have translated the 2 voice files, but had no sucess in the actual text to voice with phyton and azure.
I hope you can do the actual creation, the right neural settings is supposed to be proper chosen.

@HThuren
Copy link
Contributor Author

HThuren commented Oct 9, 2022

Hi @pfeerick, do you have a possibility to try to merge this PR and run the generate of danish voices ?

@pfeerick
Copy link
Member

Yup. At a glance, it looks fine, and it's generally better for me to do the generation anyway since then I foot the bill if it runs over ;)

@pfeerick
Copy link
Member

Ok, you might need to re-save those CSV files... they need to be UTF-8 formatted/encoded, otherwise the "special symbols" won't come through properly.

@HThuren
Copy link
Contributor Author

HThuren commented Oct 12, 2022

Right, i have made a conversion by ultraedit to uft8, but is it right looking ?

@pfeerick
Copy link
Member

I'm on mobile atm, but from the github change view it seems right, getting the proper characters now instead of the nasty unknown diamond questionmark character. Next step will be to run the generator script in about an hour and see if it chokes again ;)

@HThuren
Copy link
Contributor Author

HThuren commented Oct 12, 2022

Very god, thx

@pfeerick
Copy link
Member

pfeerick commented Oct 13, 2022

Right, so had to fix up some issues with the double quotes (yay, build-checks.py is earning it's keep!) and after that, they generated fine. I'll merge and trigger a release build and then you'll be able to get the final normalised zip file and see how they sound.

@pfeerick pfeerick changed the title Danish voice feat: Add Danish voice Oct 13, 2022
@pfeerick pfeerick merged commit 79e3ac1 into EdgeTX:main Oct 13, 2022
@HThuren
Copy link
Contributor Author

HThuren commented Oct 14, 2022

Thank you, great job by you, most ok, but created a new PR #54 for minor changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants