release builder should strip v from version tag
#73
Comments
|
Hi @pfeerick, is this still an issue? Subsidiary question: is it safe to assume that the interface with Buddy and Companion is restricted to the GitHub releases page? |
|
As far as I know - I've not looked any further into this. And yes, just via the releases API. |
|
Checking if I'm understanding the issue correctly, and if I'm reading the code correctly:
... does that mean that the last release wasn't created by the release workflow? (Or that the asset names were edited before upload?) |
|
Releases can be edited and files renamed after release ;) so you are
reading it correctly, the names were edited after release to correct for
the aforementioned deviation from prior behaviour.
…On Fri, 5 Jan 2024, 9:59 pm Gonzalo Bulnes Guilpain, < ***@***.***> wrote:
Checking if I'm understanding the issue correctly, and if I'm reading the
code correctly:
- The assets from the last release
<https://github.com/EdgeTX/edgetx-sdcard-sounds/releases/tag/v2.9.0>
don't include the v in their names (e.g.
edgetx-sdcard-sounds-cz-2.9.0.zip)
- The current release.sh script does create ZIP files with the content
of the VERSION variable in their names
- The VERSION variable does contains a prefix, e.g. v2.9.0 because the
tags contain it (code
<https://github.com/EdgeTX/edgetx-sdcard-sounds/blob/3093192f9f8aa2328cfc1f59d10bfc005ff33d17/.github/workflows/build_release.yml#L34-L35>,
tag
<https://github.com/EdgeTX/edgetx-sdcard-sounds/releases/tag/v2.9.0>)
... does that mean that the last release wasn't created by the release
workflow? (Or that the asset names were edited before upload?)
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KM2PKYZZG2XJRQQ2CTYM7TITAVCNFSM6AAAAAAZ3763YCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGU2TIOJRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version tags have the
vpresent, but it seems like from past releases this hasn't been included in the filename. Until I've ascertained the collateral damage to Buddy and Companion that would result from leaving this,release.shshould strip it out.The text was updated successfully, but these errors were encountered: