Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Invites on Android: AppInviteApi has been deprecated #478

Closed
sserdyuk opened this issue Sep 5, 2017 · 5 comments
Closed

Invites on Android: AppInviteApi has been deprecated #478

sserdyuk opened this issue Sep 5, 2017 · 5 comments
Assignees
Milestone

Comments

@sserdyuk
Copy link
Contributor

sserdyuk commented Sep 5, 2017

AppInviteApi has been deprecated. Please consider upgrading to current API.
https://developers.google.com/android/reference/com/google/android/gms/appinvite/AppInviteApi

@EddyVerbruggen
Copy link
Owner

Yeah you've probably seen this as well - I've pushed an update that fixes the TODO mentioned.

If I push a new version to npm, can you perhaps test it?

@sserdyuk
Copy link
Contributor Author

sserdyuk commented Sep 8, 2017

@EddyVerbruggen Yes, I can test it, but my test scenario is not app-to-app sharing but rather web-to-app conversion, where the website generates a FB dynamic link, and the app gets context upon installation. It doesn't work with the current version of plugin, but it does with the getDynamicLink() API that @dbeulen implemented in his fork https://github.com/dbeulen/nativescript-plugin-firebase, so, I should be able to test your implementation as well.

@EddyVerbruggen
Copy link
Owner

Do me a favor and mention that in the PR. Finding time to review and test PRs is often the only reason those don't get merged ;)

@sserdyuk
Copy link
Contributor Author

sserdyuk commented Sep 8, 2017

@EddyVerbruggen Hey, it wasn't me :)

@EddyVerbruggen
Copy link
Owner

LOL - no I meant if you test someones PR give it a thumbs up when it works. Just a little tip, I value your contribution to this topic very much already!

EddyVerbruggen added a commit that referenced this issue Sep 8, 2017
#479 Is anybody using the invites part? I can't get the deeplink or invitation id.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants