Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Adding ability to (un/)subscribe to topics at firebase #262

Merged
merged 4 commits into from
Jan 17, 2017

Conversation

markosko
Copy link
Contributor

Tested and works.
Have done only for android as i don't have Mac so can't test iOS but it's almost same way at iOS part.

Enable using of topics in android
Enable using of topics in Android
@rcluan
Copy link

rcluan commented Jan 16, 2017

Hi, @markosko . In your unsubscribe method shouldn't be unsubscribeFromTopic() instead of unsubscribeToTopic() when using com.google.firebase.messaging.FirebaseMessaging.getInstance()?

@markosko
Copy link
Contributor Author

Quite possible as i copied some things between lines :D i will change it :)

@rcluan
Copy link

rcluan commented Jan 16, 2017

I've tested and it's working like a charm both subscribe and unsubscribe methods. =D well done

@EddyVerbruggen
Copy link
Owner

Cool! Looks good to me as well. Let's merge this, or do you want to add a bit of documentation first? I can do that if you don't feel like it ;)

@markosko
Copy link
Contributor Author

Dont mind to do some docs, but can someone later pull up ios side so that we have both platforms in sync ? :) tommorow I can add docs

@EddyVerbruggen
Copy link
Owner

Sweet, I'll take care of iOS as I'm planning on doing some maintenance work for this plugin in the next few days anyway.

@markosko
Copy link
Contributor Author

and add it to messaging docs part right ?

@markosko
Copy link
Contributor Author

and one more thing @EddyVerbruggen should I add info to docs about only android will be temporary available or no need for that ?

@EddyVerbruggen
Copy link
Owner

@markosko I'll look at it now and take care of any docs changes. Thanks!!

@EddyVerbruggen EddyVerbruggen merged commit 8f46cbd into EddyVerbruggen:master Jan 17, 2017
EddyVerbruggen added a commit that referenced this pull request Jan 17, 2017
EddyVerbruggen added a commit that referenced this pull request Jan 18, 2017
EddyVerbruggen added a commit that referenced this pull request Apr 18, 2017
Adding ability to (un/)subscribe to topics at firebase
EddyVerbruggen added a commit that referenced this pull request Apr 18, 2017
EddyVerbruggen added a commit that referenced this pull request Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants